Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force specifying a module for custom scalars #245

Closed
tomhoule opened this issue Jul 12, 2019 · 2 comments · Fixed by #354
Closed

Force specifying a module for custom scalars #245

tomhoule opened this issue Jul 12, 2019 · 2 comments · Fixed by #354
Labels
help wanted Extra attention is needed

Comments

@tomhoule
Copy link
Member

One of the usability issues with the library is that we can't provide good errors for custom scalars (either the types are visible from the generated code, or they're not). In the presence of custom scalars in generated code, we could force the user of the library to specify a module to import the custom scalar types from, as a derive attribute.

Feedback on this would be appreciated before me or someone else implements it :)

@miterst
Copy link
Contributor

miterst commented Nov 11, 2020

@tomhoule would be very useful to have this option available. Is someone already working on it?

Maybe something like custom_scalar_provider=.... where one can provide the path to the module that implements the necessary scalars or fallback to super::.. if not present.

If help is sill needed me and some of my colleagues can give you a hand with this.

@tomhoule
Copy link
Member Author

Nobody is actively working on this crate at the moment (I don't have time). I would be able to review and merge PRs, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants