Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about Tanka deploying test resources #1329

Merged
merged 1 commit into from
Mar 10, 2025
Merged

docs: add note about Tanka deploying test resources #1329

merged 1 commit into from
Mar 10, 2025

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Jan 30, 2025

This behaviour was previously undocumented. See
#550 for more context.

@zerok
docs: add note about Tanka deploying test resources
e1c8547 
This behaviour was previously undocumented. See
#550 for more context.
@zerok zerok requested a review from a team as a code owner January 30, 2025 10:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-10 09:59 UTC

@zerok zerok mentioned this pull request Jan 30, 2025
Open
iainlane
iainlane approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this default? We're still pre-1.0 so we can do this in a new version. Or is disabling this more of a niche thing?

@zerok
Copy link
Contributor Author

zerok commented Jan 30, 2025

Good question. The default in helm template is to have these run and in helm install there is no such option. Based on that, I think the expected behaviour would not to include those test resources since we use helm template for helm install-like scenarios.

@zerok
Copy link
Contributor Author

zerok commented Mar 10, 2025

Will merge this now. If more people run into this issue, we should consider updating the defaults here, though.

@zerok zerok added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit d54c97f Mar 10, 2025
10 checks passed
@zerok zerok deleted the zerok/docs-skip-tests branch March 10, 2025 09:57
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerok @iainlane