remove organization maintenance mode + fix integration maintenance mode #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
force-pushed
the
jorlando/remove-org-maintenance-mode
branch
from
fe39214 to
eb1d549
Compare
joeyorlando
commented
Jul 12, 2023
Comment on lines
+76
to
+78
| # TODO: in a subsequent PR, remove the inheritance from MaintainableObject (plus generate the database migration file) | ||
| # this will remove the maintenance related columns that're no longer used on the organization object | ||
| # class Organization(models.Model): |
There was a problem hiding this comment.
these columns will be removed in a subsequent PR, for now I just removed any reference to them. I believe if we remove them in this PR, it'd cause a brief period of HTTP 500s where Organization serializers in pods running the old version fail to find these columns in the database (because they were just dropped).
joeyorlando
commented
Jul 12, 2023
| const maintenanceModeEnabledTooltip = page.getByTestId(remainingTimeTooltipTestId); | ||
| await maintenanceModeEnabledTooltip.waitFor({ state: 'visible' }); | ||
|
|
||
| expect(await page.getByTestId(`${remainingTimeTooltipTestId}-text`).innerText()).toContain(REMAINING_TIME_TEXT); |
There was a problem hiding this comment.
TODO
- add step to create a few alert groups and assert they're grouped based on which mode we selected
- stop maintenance
joeyorlando
changed the title
joeyorlando
added
the
pr:no public docs
joeyorlando
commented
Jul 12, 2023
Comment on lines
+38
to
+51
| const handleSubmit = useCallback(async (data) => { | ||
| try { | ||
| await alertReceiveChannelStore.startMaintenanceMode( | ||
| initialData.alert_receive_channel_id, | ||
| data.mode, | ||
| data.duration, | ||
| data.alert_receive_channel_id | ||
| ) | ||
| .then(() => { | ||
| onHide(); | ||
| onUpdate(); | ||
| data.duration | ||
| ); | ||
|
|
||
| openNotification('Maintenance has been started'); | ||
| }) | ||
| .catch(showApiError); | ||
| onHide(); | ||
| onUpdate(); | ||
| openNotification('Maintenance has been started'); | ||
| } catch (err) { | ||
| showApiError(err); | ||
| } |
There was a problem hiding this comment.
this was the main fix on the UI for starting maintenance mode
Comment on lines
+949
to
+955
| async function onStopMaintenance() { | ||
| setConfirmModal(undefined); | ||
|
|
||
| maintenanceStore | ||
| .stopMaintenanceMode(MaintenanceType.alert_receive_channel, id) | ||
| .then(() => maintenanceStore.updateMaintenances()) | ||
| .then(() => openNotification('Maintenance has been stopped')) | ||
| .then(() => alertReceiveChannelStore.updateItem(alertReceiveChannel.id)); | ||
| await alertReceiveChannelStore.stopMaintenanceMode(id); | ||
|
|
||
| openNotification('Maintenance has been stopped'); | ||
| await alertReceiveChannelStore.updateItem(id); |
There was a problem hiding this comment.
main fix on the UI for stopping maintenance mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)