Skip to content

Commit 46b39b2

Browse files
authored
Remove resolved and acknowledged filters as we switched to status (#1201)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated
1 parent 615a2e8 commit 46b39b2

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Added
1111

1212
- Add Slack slash command allowing to trigger a direct page via a manually created alert group
13+
- Remove resolved and acknowledged filters as we switched to status ([#1201](https://github.com/grafana/oncall/pull/1201))
1314
- Add sync with grafana on /users and /teams api calls from terraform plugin
1415

1516
### Changed

engine/apps/api/views/alert_group.py

-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ class Meta:
9191
model = AlertGroup
9292
fields = [
9393
"id__in",
94-
"resolved",
95-
"acknowledged",
9694
"started_at_gte",
9795
"started_at_lte",
9896
"resolved_at_lte",

grafana-plugin/src/models/alertgroup/alertgroup.ts

-6
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,6 @@ export class AlertGroupStore extends BaseStore {
314314
const result = await makeRequest(`${this.path}stats/`, {
315315
params: {
316316
...this.incidentFilters,
317-
resolved: false,
318-
acknowledged: false,
319317
status: [IncidentStatus.New],
320318
},
321319
});
@@ -327,8 +325,6 @@ export class AlertGroupStore extends BaseStore {
327325
const result = await makeRequest(`${this.path}stats/`, {
328326
params: {
329327
...this.incidentFilters,
330-
resolved: false,
331-
acknowledged: true,
332328
status: [IncidentStatus.Acknowledged],
333329
},
334330
});
@@ -341,7 +337,6 @@ export class AlertGroupStore extends BaseStore {
341337
const result = await makeRequest(`${this.path}stats/`, {
342338
params: {
343339
...this.incidentFilters,
344-
resolved: true,
345340
status: [IncidentStatus.Resolved],
346341
},
347342
});
@@ -354,7 +349,6 @@ export class AlertGroupStore extends BaseStore {
354349
const result = await makeRequest(`${this.path}stats/`, {
355350
params: {
356351
...this.incidentFilters,
357-
silenced: true,
358352
status: [IncidentStatus.Silenced],
359353
},
360354
});

0 commit comments

Comments
 (0)