Dependencies: Update angularjs to 1.8.2 #28736
Merged
+90
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
area/security
dependencies
torkelo
requested review from
a team,
jackw and
dprokop
and removed request for
a team
|
@daniellee maybe you could also have a look with your instance full of plugins? |
aknuds1
pushed a commit
that referenced
this pull request
Nov 5, 2020
* Angular: Update to angukar v1.8 with backward compatability monkey patches * Update fix * Updated * Updated * Fixes * Update wording * Update
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Angular: Update to angukar v1.8 with backward compatability monkey patches * Update fix * Updated * Updated * Fixes * Update wording * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes the feature of pre assigned bindings. In order not to break all old angular plugins I have monkey patched $injector.invoke to handle the common plugin controller cases that makes sure they will still work.
Release notice breaking change
Plugin compatibility
We have upgraded AngularJS from version 1.6.6 to 1.8.2. Due to this upgrade some old angular plugins might stop working and will require a small update. This is due to the deprecation and removal of pre-assigned bindings. So if your custom angular controllers expect component bindings in the controller constructor you need to move this code to an
$onInitfunction. For more details on how to migrate AngularJS code open the migration guide and search for pre-assigning bindings.In order not to break all angular panel plugins and data sources we have some custom angular inject behavior that makes sure that bindings for these controllers are still set before constructor is called so many old angular panels and data source plugins will still work.