Skip to content

Commit e4e2f8e

Browse files
msabramoBoboTiG
andauthored
style: run black & isort on inotify (#1015)
* Run black on inotify Run `black` on `src/watchdog/observers/inotify.py`. Fixes failing `flake8` tests: Before: ------- ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●) $ python -m tox -e flake8 flake8: install_deps> python -I -m pip install -r requirements-tests.txt .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: install_package_deps> python -I -m pip install 'PyYAML>=3.10' flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/12/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl flake8: commands[0]> python -m flake8 docs tools src tests setup.py src/watchdog/observers/inotify.py:224:86: W504 line break after binary operator src/watchdog/observers/inotify.py:225:88: W504 line break after binary operator flake8: exit 1 (0.40 seconds) /Users/abramowi/Code/OpenSource/watchdog> python -m flake8 docs tools src tests setup.py pid=76654 .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: FAIL code 1 (9.23=setup[8.83]+cmd[0.40] seconds) evaluation failed :( (10.10 seconds) ``` After: ------ ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●) $ python -m tox -e flake8 .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/13/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl flake8: commands[0]> python -m flake8 docs tools src tests setup.py .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: OK (1.59=setup[1.11]+cmd[0.48] seconds) congratulations :) (2.45 seconds) ``` * Create pyproject.toml * Run black again * Run isort --------- Co-authored-by: Mickaël Schoentgen <[email protected]>
1 parent 52d8692 commit e4e2f8e

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

pyproject.toml

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[tool.black]
2+
target-version = ["py38"]
3+
line-length = 120
4+
safe = true
5+
6+
[tool.isort]
7+
profile = "black"

src/watchdog/observers/inotify.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,13 @@ def get_event_mask_from_filter(self):
221221
elif cls in (DirCreatedEvent, FileCreatedEvent):
222222
event_mask |= InotifyConstants.IN_MOVE | InotifyConstants.IN_CREATE
223223
elif cls is DirModifiedEvent:
224-
event_mask |= (InotifyConstants.IN_MOVE | InotifyConstants.IN_ATTRIB |
225-
InotifyConstants.IN_MODIFY | InotifyConstants.IN_CREATE |
226-
InotifyConstants.IN_CLOSE_WRITE)
224+
event_mask |= (
225+
InotifyConstants.IN_MOVE
226+
| InotifyConstants.IN_ATTRIB
227+
| InotifyConstants.IN_MODIFY
228+
| InotifyConstants.IN_CREATE
229+
| InotifyConstants.IN_CLOSE_WRITE
230+
)
227231
elif cls is FileModifiedEvent:
228232
event_mask |= InotifyConstants.IN_ATTRIB | InotifyConstants.IN_MODIFY
229233
elif cls in (DirDeletedEvent, FileDeletedEvent):

0 commit comments

Comments
 (0)