Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage check failing in python-assured-workloads #1644

Closed
parthea opened this issue Apr 13, 2023 · 1 comment
Closed

Code coverage check failing in python-assured-workloads #1644

parthea opened this issue Apr 13, 2023 · 1 comment
Assignees
@parthea

Comments

@parthea
Copy link
Contributor

parthea commented Apr 13, 2023

The code coverage for python-assured-workloads is 99% as can be see in https://github.com/googleapis/python-assured-workloads/actions/runs/4666486762/jobs/8261147131?pr=241. We require 100% code coverage in the mono repository.

There are 2 issues that need to be addressed to bring code coverage to 100%.

  1. Remove REST methods for rpcs which do not have http annotations. Such as this one.

  2. Ensure that code formatting is turned off when pragma: no branch is used because pragma: no branch does not work across multiple lines. Pragmas on continued long lines don't work nedbat/coveragepy#754
This was referenced Apr 13, 2023
Merged
Merged
@parthea
Copy link
Contributor Author

parthea commented Apr 17, 2023

Both issues have been addressed.

@parthea parthea closed this as completed Apr 17, 2023
@parthea parthea self-assigned this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parthea