Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect isMutable on KSPropertyDeclaration from a JAVA_LIB in 2.1.10-1.0.30 #2346

Closed
danysantiago opened this issue Feb 20, 2025 · 3 comments · Fixed by #2350
Closed

Incorrect isMutable on KSPropertyDeclaration from a JAVA_LIB in 2.1.10-1.0.30 #2346

danysantiago opened this issue Feb 20, 2025 · 3 comments · Fixed by #2350
Milestone

Comments

@danysantiago
Copy link
Member

We are seeing a regression when updating KSP from 2.1.10-1.0.29 to 2.1.10-1.0.30 where KSPropertyDeclaration.isMutable is returning true for a public non-final field in a compiled Java source.

The test in androidx is https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspFieldElementTest.kt;l=101

@liutikas
Copy link

Note, this is super important to fix soon as KGP 2.1.20 is coming soon and there is only 1.0.30 version of KSP that is compatible with KGP 2.1.20.

@ting-yuan
Copy link
Collaborator

KSPropertyDeclaration.isMutable is returning true for a public non-final field in a compiled Java source.

Isn't this the desired behavior? Or did you mean it is incorrectly returning false?

@danysantiago
Copy link
Member Author

KSPropertyDeclaration.isMutable is returning true for a public non-final field in a compiled Java source.

Isn't this the desired behavior? Or did you mean it is incorrectly returning false?

I'm so sorry, it was a typo, I meant it is incorrectly returning false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants