[ksp2] getJavaWildcard does not return wildcard for List param (different with kapt/ksp1)

[acejingbo]

For a method, if it have List<Foo> param,

• in ksp1, getJavaWildcard will make it List<out Foo>
• in ksp2, getJavaWildcard will make it List<Foo>.

This has caused lots of difference in codegen, which then cause errors like did not override, etc.

Repro

• Patch acejingbo@1080402. In this commit, I
  • copied the existing test class in javaWildcard2 but without the @JvmSupressWildcard on class level.
  • copied the ksp1 output to ksp1 test expected result.
  • copied the ksp1 output to ksp2 test expected result, and reordered to match ksp2
• Run :compiler-plugin:test: See succeed.
• Run :kotlin-analysis-api:test: See failure. Meaning expected (ksp1 output) have difference with actual (ksp2 output)

Specifically, you can see things like numberList : List<Number> output numberList : List<out Number> in ksp1 but output numberList : List<Number> in ksp2

[acejingbo]

Personal guesses:

• I found the behavior only differ for types without a explicit @JvmSuppressWildcard or @JvmWildcard. If you have a @JvmWildcard on the type, or a @JvmSupressWildcard(supress=true or false) on parent class declaration, then both ksp1 and ksp2 will match the annotation. In other word, for function param type, the ksp1's default behavior seems to be doing jvmwildcard, while ksp2's default behavior seems to be suppressing jvm wildcard.
• For specific code differerence, i breakpoint and found KSP1 and KSP2 both have skipDeclarationSiteWildcardsIfPossible=true for value parameters. In ksp2 that cause it to use INVARIANT directly, while in ksp1 it didn’t fall into that condition because isMostPreciseCovariantArgument=false (Ksp2 don’t have this check).
  KSP1: https://github.com/JetBrains/kotlin/blob/2332ea36eb7a8d1eb974d3d12cb9326de10fd0f0/compiler/backend/src/org/jetbrains/kotlin/codegen/state/KotlinTypeMapper.kt#L662-L664
  KSP2: https://github.com/google/ksp/blob/main/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt#L720-L722