This repository was archived by the owner on Jun 19, 2022. It is now read-only.
Implementation of Targets that knows it's backed by a configmap #830
Labels
area/broker
kind/feature-request
New feature or request
priority/2
Nice to have feature but doesn't block current release defined by release/*
release/1
Milestone
Problem
Currently the Broker reconciler uses the in-memory variant of config.Targets to aggregate broker and trigger routing and handles persisting that to a configmap. This adds a lot of complexity to the reconciler: since reconciler threads can process multiple brokers at once, it has to run a separate goroutine to update the configmap safely. It would be nicer if there were a variant of Targets that wrapped up all the configmap load/store logic in the same interface.
It's also challenging to test this logic with normal reconciler table tests, because the configmap update happens outside the Reconcile method.
Persona:
Contributor
Exit Criteria
The Broker reconciler can delegate load/store to a separate library.
Additional context (optional)
This should probably wait until #815 is resolved.
The text was updated successfully, but these errors were encountered: