Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slug missing from manifest handshake response #2028

Closed
rpelliard opened this issue Aug 4, 2021 · 2 comments
Closed

Slug missing from manifest handshake response #2028

rpelliard opened this issue Aug 4, 2021 · 2 comments

Comments

@rpelliard
Copy link
Contributor

The AppConfig struct, used to represent the result of a manifest handshake, seems to be missing the slug field which is returned by GitHub.
Is that on purpose, or should it be added ?

Happy to submit a PR to add it, let me know.
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 4, 2021 •
edited
Loading

Thank you, @rpelliard .
It is not intentional. Please feel free to submit a PR.

Please check out our CONTRIBUTING.md file for helpful information.

@rpelliard
Copy link
Contributor Author

@gmlewis Here it is: #2029

@gmlewis gmlewis closed this as completed in d8a66d0 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpelliard @gmlewis