Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/loader: TestStdlib failures #72122

Open
gopherbot opened this issue Mar 6, 2025 · 12 comments
Open

x/tools/go/loader: TestStdlib failures #72122

gopherbot opened this issue Mar 6, 2025 · 12 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestStdlib
--- FAIL: TestStdlib (88.64s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2119 [running]:
testing.tRunner.func1.2({0xe463080, 0xe62ded0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0xe463080?, 0xe62ded0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0002294a0, 0xc0360cefc0, {0xc00bec6360, 0x22, 0x22}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc0009ac000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0075f5500)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0075f5500, 0xe4a9458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-05 19:59 x_tools-gotip-darwin-amd64-longtest tools@25a90bef go@cad4dca5 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (88.64s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2119 [running]:
testing.tRunner.func1.2({0xe463080, 0xe62ded0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0xe463080?, 0xe62ded0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0002294a0, 0xc0360cefc0, {0xc00bec6360, 0x22, 0x22}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc0009ac000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0075f5500)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2452999121/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0075f5500, 0xe4a9458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 6, 2025
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 6, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-05 18:38 x_tools-gotip-darwin-amd64-longtest tools@db6008cb go@cad4dca5 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (84.80s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2147 [running]:
testing.tRunner.func1.2({0x7d60080, 0x7f2aed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x7d60080?, 0x7f2aed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc000642a80, 0xc018f15380, {0xc019c76988, 0x1, 0x1}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo422986406/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc00006a000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo422986406/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc000083180)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo422986406/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc000083180, 0x7da6458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-05 16:17 x_tools-gotip-darwin-amd64-longtest tools@07219402 go@cad4dca5 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (77.80s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2071 [running]:
testing.tRunner.func1.2({0x10151080, 0x1031bed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x10151080?, 0x1031bed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0000dad80, 0xc00a8bef00, {0xc049dcad80, 0x5, 0x5}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3828137159/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc000046000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3828137159/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc008442000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3828137159/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc008442000, 0x10197458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-05 20:18 x_tools-gotip-darwin-amd64-longtest tools@6a5b66be go@938b6c15 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (81.00s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2082 [running]:
testing.tRunner.func1.2({0x7822080, 0x79eced0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x7822080?, 0x79eced0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc00027e480, 0xc00c824480, {0xc002de4188, 0x1, 0x1}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2631517673/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc00005e000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2631517673/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc00ab04540)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2631517673/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc00ab04540, 0x7868458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@1cf6b502 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (84.01s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2108 [running]:
testing.tRunner.func1.2({0xccdf080, 0xcea9ed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0xccdf080?, 0xcea9ed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0000940c0, 0xc060125200, {0xc01291dd60, 0x2, 0x2}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2037141390/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc001040000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2037141390/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0072f0380)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2037141390/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0072f0380, 0xcd25458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@24d22352 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (79.50s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2112 [running]:
testing.tRunner.func1.2({0xd0b9080, 0xd283ed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0xd0b9080?, 0xd283ed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0001d0660, 0xc008865800, {0xc0608deb70, 0x5, 0x5}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2624835738/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc000046000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2624835738/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0056b4540)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2624835738/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0056b4540, 0xd0ff458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@9bd21607 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (67.99s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 1904 [running]:
testing.tRunner.func1.2({0x6ab6080, 0x6c80ed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x6ab6080?, 0x6c80ed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0005902a0, 0xc00ae04a80, {0xc00f6b8900, 0x2, 0x2}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2727840031/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc000046000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2727840031/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0069a8000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo2727840031/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0069a8000, 0x6afc458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@f55bb135 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (106.10s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2083 [running]:
testing.tRunner.func1.2({0x95ad080, 0x9777ed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x95ad080?, 0x9777ed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0001dc540, 0xc055e409c0, {0xc05245b9a8, 0x1, 0x1}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3097948436/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc001074000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3097948436/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0056828c0)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3097948436/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0056828c0, 0x95f3458)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@8a7742e7 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (78.03s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 1783 [running]:
testing.tRunner.func1.2({0x9790100, 0x995aed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0x9790100?, 0x995aed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc0000955c0, 0xc02c5f5980, {0xc074617d18, 0x1, 0x1}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3282550801/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc000046000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3282550801/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc0072661c0)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3282550801/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc0072661c0, 0x97d6578)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/loader" && test == "TestStdlib"
2025-03-06 18:34 x_tools-gotip-darwin-amd64-longtest tools@b08c7a26 go@232dfd22 x/tools/go/loader.TestStdlib (log) 
=== RUN   TestStdlib
--- FAIL: TestStdlib (111.12s)
panic: assignment to entry in nil map [recovered, reraised]

goroutine 2133 [running]:
testing.tRunner.func1.2({0xb959100, 0xbb23ed0})
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1740 +0x21c
testing.tRunner.func1()
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1743 +0x363
panic({0xb959100?, 0xbb23ed0?})
...
golang.org/x/tools/go/loader.(*importer).addFiles(0xc00005cc60, 0xc013a22600, {0xc00ed23cc0, 0x2, 0x2}, 0x0?)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3049520844/go/loader/loader.go:1006 +0xe5
golang.org/x/tools/go/loader.(*Config).Load(0xc003a4c000)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3049520844/go/loader/loader.go:576 +0x806
golang.org/x/tools/go/loader_test.TestStdlib(0xc006ed21c0)
	/Users/swarming/.swarming/w/ir/x/w/targetrepo3049520844/go/loader/stdlib_test.go:53 +0x2f3
testing.tRunner(0xc006ed21c0, 0xb99f578)
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1798 +0xea
created by testing.(*T).Run in goroutine 1
	/Users/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1857 +0x413

— watchflakes

@ianlancetaylor
Copy link
Member

CC @golang/tools-team

There seem to be consistent failures of x/tools/go/loader TestStdlib on the darwin-amd64-longtest builder.

@ianlancetaylor
Copy link
Member

Fails on Linux as well.

@ianlancetaylor
Copy link
Member

Could well be due to https://go.dev/cl/650796. CC @findleyr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: No status
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot