Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can approve or reject his/her own PR #4728

Closed
2 of 7 tasks
adelowo opened this issue Aug 16, 2018 · 4 comments · Fixed by #4729
Closed
2 of 7 tasks

User can approve or reject his/her own PR #4728

adelowo opened this issue Aug 16, 2018 · 4 comments · Fixed by #4729
Labels
Milestone

Comments

@adelowo
Copy link
Member

adelowo commented Aug 16, 2018

Description

A user can approve and/or reject a PR (s)he created... This behaviour doesn't exist on Github for example

PS : (s)he can still merge the PR but cannot leave an approval or rejection review

...

screen shot 2018-08-16 at 15 27 51

screen shot 2018-08-16 at 15 27 54

@lunny
Copy link
Member

lunny commented Aug 16, 2018

@adelowo on Github you can merge yourself PR since I did that every day. So I think this should be an option on protected branch and defaultly allow user to merge himself PRs.

@adelowo
Copy link
Member Author

adelowo commented Aug 16, 2018

This is not for merging but for reviewing only.... You obviously can merge but not review

@adelowo
Copy link
Member Author

adelowo commented Aug 16, 2018

@lunny uploaded some screenshots above... Hovering over those buttons give you the warning information

@lunny
Copy link
Member

lunny commented Aug 16, 2018

@adelowo you are right.

@lunny lunny added the type/bug label Aug 16, 2018
@lunny lunny added this to the 1.6.0 milestone Aug 16, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants