Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pagination of explore page does not honor the sort attribute. #1980

Closed
1 of 7 tasks
ThingsHybrid opened this issue Jun 15, 2017 · 1 comment · Fixed by #2013
Closed
1 of 7 tasks

The pagination of explore page does not honor the sort attribute. #1980

ThingsHybrid opened this issue Jun 15, 2017 · 1 comment · Fixed by #2013
Labels
Milestone

Comments

@ThingsHybrid
Copy link

  • Gitea version (or commit ref): 1.1.1 / 1.1.2
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

The explore page has the 'sort' option on dropdown menu. The sorting works on the first page. As soon as the 'Next' page button is clicked, it goes to the next page; however, the sort=[algorithm] is lost. If I manually add the query attribute to the url, it works correctly. I think this is a minor bug.

For example:
The url "/explore/repos?page=2&q=&tab=" should have been "/explore/repos?sort=alphabetically&q=&tab=&page=2" where the "sort=[algorithm]" should be included.

@lunny lunny added the type/bug label Jun 16, 2017
@lunny lunny added this to the 1.x.x milestone Jun 16, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jun 19, 2017

this is the file that needs fixing: https://github.com/go-gitea/gitea/blob/master/templates/base/paginate.tmpl

@lunny lunny modified the milestones: 1.2.0, 1.x.x Jun 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants