fix bug not to trim space of login username (#1796)

lunny · appleboy · commit 19d889daa248 · 2017-05-25T00:12:00.000+08:00
diff --git a/models/login_source.go b/models/login_source.go
@@ -641,7 +641,12 @@ func UserSignIn(username, password string) (*User, error) {
 			}
 		}
 	} else {
-		user = &User{LowerName: strings.ToLower(strings.TrimSpace(username))}
+		trimmedUsername := strings.TrimSpace(username)
+		if len(trimmedUsername) == 0 {
+			return nil, ErrUserNotExist{0, username, 0}
+		}
+
+		user = &User{LowerName: strings.ToLower(trimmedUsername)}
 	}
 
 	hasUser, err := x.Get(user)

Original file line number	Diff line number	Diff line change
`@@ -641,7 +641,12 @@ func UserSignIn(username, password string) (*User, error) {`
`641`	`641`	`}`
`642`	`642`	`}`
`643`	`643`	`} else {`
`644`		`- user = &User{LowerName: strings.ToLower(strings.TrimSpace(username))}`
	`644`	`+ trimmedUsername := strings.TrimSpace(username)`
	`645`	`+ if len(trimmedUsername) == 0 {`
	`646`	`+ return nil, ErrUserNotExist{0, username, 0}`
	`647`	`+ }`
	`648`	`+`
	`649`	`+ user = &User{LowerName: strings.ToLower(trimmedUsername)}`
`645`	`650`	`}`
`646`	`651`
`647`	`652`	`hasUser, err := x.Get(user)`