Skip to content

Commit d0a5d16

Browse files
ComputerDruidFuchsia Internal LUCI
authored andcommitted
Revert "[rust] allow unused-macro-rules to unblock toolchain roll"
This reverts commit 9d8f965. Reason for revert: lint is allow-by-default after rust-lang/rust#97032 Original change's description: > [rust] allow unused-macro-rules to unblock toolchain roll > > Bug: 100318 > Change-Id: Ided9428282c66e63cda934a5f456223750703179 > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/679506 > Reviewed-by: Joseph Ryan <[email protected]> > Fuchsia-Auto-Submit: Dan Johnson <[email protected]> > Reviewed-by: Tyler Mandry <[email protected]> > Commit-Queue: Auto-Submit <[email protected]> Bug: 100318 Change-Id: I2ebf0b0e9c9e28d8a2588fc92dfe7428c77ca4cf Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/679988 Reviewed-by: RubberStamper 🤖 <[email protected]> Commit-Queue: Dan Johnson <[email protected]> Reviewed-by: Joseph Ryan <[email protected]>
1 parent c85c35c commit d0a5d16

File tree

13 files changed

+0
-30
lines changed

13 files changed

+0
-30
lines changed

src/connectivity/lib/internet-checksum/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ type Accumulator = u64;
161161
// on other platforms.
162162
const SMALL_BUF_THRESHOLD: usize = 64;
163163

164-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
165-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
166164
/// The following macro unrolls operations on u16's to wider integers.
167165
///
168166
/// # Arguments

src/connectivity/lib/packet-formats/src/macros.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,6 @@ macro_rules! __create_protocol_enum_inner {
226226
};
227227
}
228228

229-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
230-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
231229
/// Create an enum representing a protocol number (such as IP protocol or
232230
/// EtherType).
233231
///

src/connectivity/lowpan/lib/spinel_pack/src/primitives.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ macro_rules! impl_try_array_owned_unpack_sized(
2727
}
2828
);
2929

30-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
31-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
3230
macro_rules! impl_try_pack_unpack_as_data(
3331
(u8) => {
3432
// We skip u8.

src/connectivity/network/netstack3/core/src/ip/gmp/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
1818
// This macro is used by tests in both the `igmp` and `mld` modules.
1919

20-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
21-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
2220
/// Assert that the GMP state machine for `$group` is in the given state.
2321
///
2422
/// `$ctx` is a `context::testutil::DummyCtx` whose state contains a `groups:

src/connectivity/network/netstack3/core/src/macros.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
//! Macros used in Netstack3.
66
7-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
8-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
97
macro_rules! log_unimplemented {
108
($nocrash:expr, $fmt:expr $(,$arg:expr)*) => {{
119

src/lib/cobalt/rust/src/sender.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ use {
1616
},
1717
};
1818

19-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
20-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
2119
macro_rules! gen_comment {
2220
($x:expr) => {
2321
#[doc = $x]

src/lib/mundane/src/boringssl/abort.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
1515
use std::fmt::Debug;
1616

17-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
18-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
1917
macro_rules! assert_abort {
2018
($cond:expr) => ({
2119
let cond = $cond;
@@ -32,8 +30,6 @@ macro_rules! assert_abort {
3230
});
3331
}
3432

35-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
36-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
3733
macro_rules! assert_abort_eq {
3834
($left:expr, $right:expr) => ({
3935
match (&$left, &$right) {
@@ -76,8 +72,6 @@ macro_rules! unreachable_abort {
7672
}};
7773
}
7874

79-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
80-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
8175
macro_rules! panic_abort {
8276
() => ({
8377
panic_abort!("explicit panic")

src/lib/mundane/src/boringssl/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -798,8 +798,6 @@ pub fn rsa_verify_pss_mgf1(
798798
}
799799
}
800800

801-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
802-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
803801
/// Implements `CStackWrapper` for a hash context type.
804802
///
805803
/// The caller provides doc comments, a public method name, and a private

src/lib/mundane/src/boringssl/wrapper.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ macro_rules! sealed {
2020
};
2121
}
2222

23-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
24-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
2523
macro_rules! impl_traits {
2624
(@inner $name:ident, CNew => $fn:tt) => {
2725
c_new!($name, $fn);

src/lib/storage/vfs/rust/src/path.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ impl AsRef<str> for Path {
182182
mod tests {
183183
use super::*;
184184

185-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
186-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
187185
macro_rules! simple_construction_test {
188186
(path: $str:expr, $path:ident => $body:block) => {
189187
match Path::validate_and_split($str) {

src/power/power-manager/src/types.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ macro_rules! define_float_unit {
5050
};
5151
}
5252

53-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
54-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
5553
/// Defines a measurement unit, with an underlying scalar type.
5654
macro_rules! define_unit {
5755
( $unit_type:ident, f32 ) => {

src/proc/bin/starnix/fs/fs_node.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,6 @@ macro_rules! fs_node_impl_symlink {
234234
};
235235
}
236236

237-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
238-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
239237
/// Implements [`FsNodeOps::set_xattr`] by delegating to another [`FsNodeOps`]
240238
/// object.
241239
macro_rules! fs_node_impl_xattr_delegate {

src/proc/bin/starnix/mutable_state.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,6 @@ impl<'a, B, S> ops::DerefMut for WritableState<'a, B, S> {
275275
}
276276
}
277277

278-
#[allow(unknown_lints)] // TODO(fxbug.dev/99424): remove this after toolchain roll when lint is known
279-
#[allow(unused_macro_rules)] // TODO(fxbug.dev/100318): remove unused macro rules and re-enable
280278
/// This macro matches the methods inside a `state_implementation!` macro depending on their
281279
/// visibility and mutability so that the `state_implementation!` might dispatch these to the right
282280
/// trait or implementation.

0 commit comments

Comments
 (0)