Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-chain pubkey checking for new validators #3842

Open
D4ryl00 opened this issue Feb 27, 2025 · 1 comment · May be fixed by #3925
Open

Add on-chain pubkey checking for new validators #3842

D4ryl00 opened this issue Feb 27, 2025 · 1 comment · May be fixed by #3925

Comments

@D4ryl00
Copy link
Contributor

D4ryl00 commented Feb 27, 2025

Description

If a valoper is registered with an unsupported key type (e.g. secp256k1 instead of ed25519) and GovDOA members vote YES to add it as validator without manually checking the key type, then the node will crash with the following error :

Error on ApplyBlock. Did the application crash? Please restart tendermint       {"module": "consensus", "err": "Error in validator updates: validator {g1jAddress... gpubkey... 1} is using pubkey /tm.PubKeySecp256k1, which is unsupported for consensus"}

We should prevent the node from crashing for production, and add a security mechanism like on-chain pubkey checking.

@MikaelVallenet
Copy link
Member

MikaelVallenet commented Mar 5, 2025

I'll look to add pubkey kind check ASAP for new validators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

5 participants