-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong percent-encoding of unreserved characters #311
Comments
/cc @mdiep |
Any news? |
That link seems to work fine in Chrome 36.0.1985.143. |
I can confirm that the link works for me as well. Let us know if it doesn't work for you. |
@bkeepers please reopen. In the meantime using |
I've just been hit by this. Our markdown contains ~, and the HTML contains %7E. Of three browsers tested, two send the %7E to the server and the other url-decodes to ~ before sending. This obscured what was going on. The server then failed to url-decode the %7E. Arguably the server is wrong. But even so, according to the latest applicable RFC, tilde is unreserved, and "Unreserved characters can be escaped without changing the semantics of the URI, but this should not be done unless the URI is being used in a context that does not allow the unescaped character to appear." (http://www.rfc-editor.org/rfc/rfc2396.txt) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
further activity |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Currently, Markdown percent-encodes unreserved characters. For example, this markdown expression:
generates
As you can see, the
~
has been percent-encoded to%7E
. Even if this works fine on at least Firefox, this won't work on Chrome:Click me to verify (works on Firefox 29, does not work on Chromium 34.0.1847.116).
The Percent-encoding page on Wikipedia explains that
On the contrary, the markdown 1.0.1 command-line utility produces the expected, non percent-encoded, HTML:
The text was updated successfully, but these errors were encountered: