Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travisCI fail but not found #1656

Closed
thinkerou opened this issue Nov 23, 2018 · 4 comments
Closed

travisCI fail but not found #1656

thinkerou opened this issue Nov 23, 2018 · 4 comments

Comments

@thinkerou
Copy link
Member

fail info: https://travis-ci.org/gin-gonic/gin/jobs/458636581
pull request: #1387

cc @BanzaiMan thanks!

@BanzaiMan
Copy link

What's not found? What's the problem with this build?

@thinkerou
Copy link
Member Author

@BanzaiMan Thank your reply! Sorry for not clear describe the question.

  1. use the command go test ... to execute unit test

  2. And it have some FAIL, like:

=== RUN   TestUriBinding
--- FAIL: TestUriBinding (0.00s)
    binding_test.go:690: 
        	Error Trace:	binding_test.go:690
        	Error:      	Not equal: 
        	            	expected: string("")
        	            	actual  : map[string]interface {}(map[string]interface {}(nil))
        	Test:       	TestUriBinding
  1. But it show Success, like:

image

I hope it show Fail, like:

image

Sorry, I don't know travis-ci can catch the case?

Maybe travis-ci have config which can solve it, but I'm not found it now.

Thanks again!

@BanzaiMan
Copy link

The command you are running is make test, not any of the individual go test commands. If make test exits with zero, it is successful. If you want any of the go test commands to trip the wire and cause the failure, you will have to modify your Make target to accomplish it.

@thinkerou
Copy link
Member Author

@BanzaiMan thanks, I will solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants