Skip to content

Commit fc920dc

Browse files
dmarkhamappleboy
authored andcommitted
Drop Support for go1.8 and go1.9 (#1933)
1 parent 46acb91 commit fc920dc

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

.travis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ language: go
33
matrix:
44
fast_finish: true
55
include:
6-
- go: 1.8.x
7-
- go: 1.9.x
86
- go: 1.10.x
97
- go: 1.11.x
108
env: GO111MODULE=on

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Gin is a web framework written in Go (Golang). It features a martini-like API wi
7070

7171
To install Gin package, you need to install Go and set your Go workspace first.
7272

73-
1. The first need [Go](https://golang.org/) installed (**version 1.8+ is required**), then you can use the below Go command to install Gin.
73+
1. The first need [Go](https://golang.org/) installed (**version 1.10+ is required**), then you can use the below Go command to install Gin.
7474

7575
```sh
7676
$ go get -u github.com/gin-gonic/gin

debug.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
"strings"
1414
)
1515

16-
const ginSupportMinGoVer = 8
16+
const ginSupportMinGoVer = 10
1717

1818
// IsDebugging returns true if the framework is running in debug mode.
1919
// Use SetMode(gin.ReleaseMode) to disable debug mode.
@@ -68,7 +68,7 @@ func getMinVer(v string) (uint64, error) {
6868

6969
func debugPrintWARNINGDefault() {
7070
if v, e := getMinVer(runtime.Version()); e == nil && v <= ginSupportMinGoVer {
71-
debugPrint(`[WARNING] Now Gin requires Go 1.8 or later and Go 1.9 will be required soon.
71+
debugPrint(`[WARNING] Now Gin requires Go 1.10 or later and Go 1.11 will be required soon.
7272
7373
`)
7474
}

debug_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func TestDebugPrintWARNINGDefault(t *testing.T) {
9191
})
9292
m, e := getMinVer(runtime.Version())
9393
if e == nil && m <= ginSupportMinGoVer {
94-
assert.Equal(t, "[GIN-debug] [WARNING] Now Gin requires Go 1.8 or later and Go 1.9 will be required soon.\n\n[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.\n\n", re)
94+
assert.Equal(t, "[GIN-debug] [WARNING] Now Gin requires Go 1.10 or later and Go 1.11 will be required soon.\n\n[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.\n\n", re)
9595
} else {
9696
assert.Equal(t, "[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.\n\n", re)
9797
}

0 commit comments

Comments
 (0)