Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e700312

Browse files
DanielRosenwasserandrewshie-sentry
authored andcommittedMay 12, 2025
chore(typescript): Remove baseUrl in anticipation for deprecation. (#90413)
[We recently tried to build the Sentry codebase](microsoft/typescript-go#807) with [the native port of the TypeScript compiler](https://github.com/microsoft/typescript-go). Unfortunately, the compiler issued a flood of errors because the Sentry project relies on `baseUrl` which we are leaning towards removing. Path mapping will still be supported - but `baseUrl` has not been required for path mapping since TypeScript 4.1, and has been discouraged from use. `baseUrl` occasionally permits paths that may not be intended to be valid (e.g. importing from `static/app/foo/Bar` instead of `sentry/foo/Bar`). It may also be the case that `baseUrl` can result in extra lookups, but don't quote me on that. Instead, each path can be given an explicit relative prefix (or optionally use `${configDir}`, though that is likely not ideal much of the time). This PR does exactly that and future-proofs the Sentry codebase. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
1 parent cd3ff48 commit e700312

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed
 

‎config/tsconfig.base.json

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,18 @@
9595
"experimentalDecorators": true,
9696
"resolveJsonModule": true,
9797

98-
"baseUrl": "../",
9998
"paths": {
100-
"sentry/*": ["static/app/*"],
101-
"sentry-fixture/*": ["tests/js/fixtures/*"],
102-
"sentry-test/*": ["tests/js/sentry-test/*"],
103-
"getsentry-test/*": ["tests/js/getsentry-test/*"],
104-
"sentry-images/*": ["static/images/*"],
105-
"sentry-locale/*": ["src/sentry/locale/*"],
106-
"sentry-logos/*": ["src/sentry/static/sentry/images/logos/*"],
107-
"sentry-fonts/*": ["static/fonts/*"],
108-
"getsentry/*": ["static/gsApp/*"],
109-
"getsentry-images/*": ["static/images/*"],
110-
"admin/*": ["static/gsAdmin/*"]
99+
"sentry/*": ["../static/app/*"],
100+
"sentry-fixture/*": ["../tests/js/fixtures/*"],
101+
"sentry-test/*": ["../tests/js/sentry-test/*"],
102+
"getsentry-test/*": ["../tests/js/getsentry-test/*"],
103+
"sentry-images/*": ["../static/images/*"],
104+
"sentry-locale/*": ["../src/sentry/locale/*"],
105+
"sentry-logos/*": ["../src/sentry/static/sentry/images/logos/*"],
106+
"sentry-fonts/*": ["../static/fonts/*"],
107+
"getsentry/*": ["../static/gsApp/*"],
108+
"getsentry-images/*": ["../static/images/*"],
109+
"admin/*": ["../static/gsAdmin/*"]
111110
},
112111

113112
"plugins": [

0 commit comments

Comments
 (0)
Please sign in to comment.