fix(replays): Return an error if an unsupported click attribute is selected (#53443)

Author: cmanallen

src/sentry/replays/lib/selector/parse.py

@@ -87,6 +87,11 @@ def visit_attribute(query: QueryType, attribute: Attrib) -> None:
         query.testid = attribute.value
     elif attrib == "title":
         query.title = attribute.value
+    else:
+        raise ParseError(
+            "Invalid attribute specified. Only alt, aria-label, role, data-testid, data-test-id, "
+            "and title are supported."
+        )
 
 
 def visit_class(query: QueryType, class_: Class) -> None:

tests/sentry/replays/test_organization_replay_index.py

@@ -1169,6 +1169,21 @@ def test_get_replays_filter_clicks_unsupported_selector(self):
                     == b'{"detail":"Only attribute, class, id, and tag name selectors are supported."}'
                 ), query
 
+    def test_get_replays_filter_clicks_unsupported_attribute_selector(self):
+        """Assert replays only supports a subset of selector syntax."""
+        project = self.create_project(teams=[self.team])
+        self.store_replays(mock_replay(datetime.datetime.now(), project.id, uuid.uuid4().hex))
+
+        with self.feature(REPLAYS_FEATURES):
+            queries = ["click.selector:div[xyz=test]"]
+            for query in queries:
+                response = self.client.get(self.url + f"?field=id&query={query}")
+                assert response.status_code == 400, query
+                assert response.content == (
+                    b'{"detail":"Invalid attribute specified. Only alt, aria-label, role, '
+                    b'data-testid, data-test-id, and title are supported."}'
+                ), query
+
     def test_get_replays_filter_clicks_unsupported_operators(self):
         """Assert replays only supports a subset of selector syntax."""
         project = self.create_project(teams=[self.team])