From 183eb6307ed6232424452eae058f44c5c62d9dd6 Mon Sep 17 00:00:00 2001 From: David Herberth <david.herberth@sentry.io> Date: Tue, 26 Mar 2024 12:21:01 +0100 Subject: [PATCH] ref(cardinality): Switch histogram to gauge --- relay-cardinality/src/redis/limiter.rs | 6 +++--- relay-cardinality/src/statsd.rs | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/relay-cardinality/src/redis/limiter.rs b/relay-cardinality/src/redis/limiter.rs index b2ccde01438..1bbea1ea58f 100644 --- a/relay-cardinality/src/redis/limiter.rs +++ b/relay-cardinality/src/redis/limiter.rs @@ -10,7 +10,7 @@ use crate::{ script::{CardinalityScript, Status}, state::{LimitState, RedisEntry}, }, - statsd::{CardinalityLimiterHistograms, CardinalityLimiterTimers}, + statsd::{CardinalityLimiterGauges, CardinalityLimiterTimers}, CardinalityLimit, Result, }; use relay_common::time::UnixTimestamp; @@ -63,7 +63,7 @@ impl RedisSetLimiter { let entries = state.take_entries(); metric!( - histogram(CardinalityLimiterHistograms::RedisCheckHashes) = entries.len() as u64, + gauge(CardinalityLimiterGauges::RedisCheckHashes) = entries.len() as u64, id = state.id(), ); @@ -79,7 +79,7 @@ impl RedisSetLimiter { .invoke(con, limit, scope.redis_key_ttl(), hashes, keys)?; metric!( - histogram(CardinalityLimiterHistograms::RedisSetCardinality) = result.cardinality, + gauge(CardinalityLimiterGauges::RedisSetCardinality) = result.cardinality, id = state.id(), ); diff --git a/relay-cardinality/src/statsd.rs b/relay-cardinality/src/statsd.rs index 035cedfa86b..a315bdda424 100644 --- a/relay-cardinality/src/statsd.rs +++ b/relay-cardinality/src/statsd.rs @@ -1,4 +1,4 @@ -use relay_statsd::{CounterMetric, HistogramMetric, SetMetric, TimerMetric}; +use relay_statsd::{CounterMetric, GaugeMetric, SetMetric, TimerMetric}; /// Counter metrics for the Relay Cardinality Limiter. pub enum CardinalityLimiterCounters { @@ -81,7 +81,7 @@ impl TimerMetric for CardinalityLimiterTimers { } } -pub enum CardinalityLimiterHistograms { +pub enum CardinalityLimiterGauges { /// Amount of hashes sent to Redis to check the cardinality. /// /// This metric is tagged with: @@ -96,7 +96,7 @@ pub enum CardinalityLimiterHistograms { RedisSetCardinality, } -impl HistogramMetric for CardinalityLimiterHistograms { +impl GaugeMetric for CardinalityLimiterGauges { fn name(&self) -> &'static str { match *self { #[cfg(feature = "redis")]