From fa07de8773eda24a86904e06d71d2906b843ef10 Mon Sep 17 00:00:00 2001 From: Jan Michael Auer Date: Wed, 23 Feb 2022 10:59:04 +0100 Subject: [PATCH 1/3] ref(store): Random Kafka partitioning for sessions --- relay-server/src/actors/store.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/relay-server/src/actors/store.rs b/relay-server/src/actors/store.rs index 804333bb8aa..3470c6819cd 100644 --- a/relay-server/src/actors/store.rs +++ b/relay-server/src/actors/store.rs @@ -673,8 +673,8 @@ impl KafkaMessage { Self::Attachment(message) => message.event_id.0, Self::AttachmentChunk(message) => message.event_id.0, Self::UserReport(message) => message.event_id.0, - Self::Session(message) => message.session_id, - Self::Metric(_message) => Uuid::nil(), // TODO(ja): Determine a partitioning key + Self::Session(_message) => Uuid::nil(), // Explicit random partitioning for sessions + Self::Metric(_message) => Uuid::nil(), // TODO(ja): Determine a partitioning key Self::ProfilingTrace(_message) => Uuid::nil(), // TODO(pierre): parse session_id as uuid Self::ProfilingSession(_message) => Uuid::nil(), // TODO(pierre): parse session_id as uuid }; From 3745794f6ff8f381e2b2b0417597c57bc323932c Mon Sep 17 00:00:00 2001 From: Jan Michael Auer Date: Wed, 23 Feb 2022 11:05:13 +0100 Subject: [PATCH 2/3] meta: Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42eda6b7e76..f72c3cbefca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ **Internal**: - Spread out metric aggregation over the aggregation window to avoid concentrated waves of metrics requests to the upstream every 10 seconds. Relay now applies jitter to `initial_delay` to spread out requests more evenly over time. ([#1185](https://github.com/getsentry/relay/pull/1185)) +- Use a randomized Kafka partitioning key for sessions instead of the session ID. ([#1194](https://github.com/getsentry/relay/pull/1194)) ## 22.2.0 From 6c217de82b3eb3ceb4004c6872a785fd0090e08b Mon Sep 17 00:00:00 2001 From: Jan Michael Auer Date: Thu, 10 Mar 2022 09:55:56 +0100 Subject: [PATCH 3/3] meta: Fix changelog for 21.12.0 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 09a1ed7829c..b2a310b4708 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,6 +54,7 @@ - Metrics extraction config, custom tags. ([#1141](https://github.com/getsentry/relay/pull/1141)) - Update the user agent parser (uap-core Feb 2020 to Nov 2021). This allows Relay and Sentry to infer more recent browsers, operating systems, and devices in events containing a user agent header. ([#1143](https://github.com/getsentry/relay/pull/1143), [#1145](https://github.com/getsentry/relay/pull/1145)) - Improvements to Unity OS context parsing ([#1150](https://github.com/getsentry/relay/pull/1150)) + **Bug Fixes**: - Support Unreal Engine 5 crash reports. ([#1132](https://github.com/getsentry/relay/pull/1132))