Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to create Investigation Bias with has:profile.id #2710

Closed
matejminar opened this issue Nov 9, 2023 · 1 comment · Fixed by #2715
Closed

Make it possible to create Investigation Bias with has:profile.id #2710

matejminar opened this issue Nov 9, 2023 · 1 comment · Fixed by #2715
Assignees

Comments

@matejminar
Copy link
Member

Users would like to create Investigation Biases (reservoir rules that boost Dynamic Sampling to 100%) with the condition containing has:profile.id. This ticket is about the Relay part that's needed in order for this to happen.
Jan mentioned that we don't have profile.id exposed as a queryable field, actually, it's not a field at all.

@jjbayer
Copy link
Member

jjbayer commented Nov 9, 2023

We currently have the profile ID as a field on contexts.profile.profile_id, but

  1. It's set in process_profiles, which happens after dynamic sampling.
  2. (easy part) There is no getter for it yet.

profile_id: Annotated::new(profile_id),

"contexts.unreal.crash_type" => match self.contexts.value()?.get_key("unreal")? {
super::Context::Other(context) => context.get("crash_type")?.value()?.into(),
_ => return None,
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants