Skip to content

Commit d2d6b0c

Browse files
authored
ref(cardinality): Switch histogram to gauge (#3331)
We're only interested in the max, all other information we'd get from a histogram is not really valuable here.
1 parent b0ae404 commit d2d6b0c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

relay-cardinality/src/redis/limiter.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use crate::{
1010
script::{CardinalityScript, Status},
1111
state::{LimitState, RedisEntry},
1212
},
13-
statsd::{CardinalityLimiterHistograms, CardinalityLimiterTimers},
13+
statsd::{CardinalityLimiterGauges, CardinalityLimiterTimers},
1414
CardinalityLimit, Result,
1515
};
1616
use relay_common::time::UnixTimestamp;
@@ -63,7 +63,7 @@ impl RedisSetLimiter {
6363
let entries = state.take_entries();
6464

6565
metric!(
66-
histogram(CardinalityLimiterHistograms::RedisCheckHashes) = entries.len() as u64,
66+
gauge(CardinalityLimiterGauges::RedisCheckHashes) = entries.len() as u64,
6767
id = state.id(),
6868
);
6969

@@ -79,7 +79,7 @@ impl RedisSetLimiter {
7979
.invoke(con, limit, scope.redis_key_ttl(), hashes, keys)?;
8080

8181
metric!(
82-
histogram(CardinalityLimiterHistograms::RedisSetCardinality) = result.cardinality,
82+
gauge(CardinalityLimiterGauges::RedisSetCardinality) = result.cardinality,
8383
id = state.id(),
8484
);
8585

relay-cardinality/src/statsd.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use relay_statsd::{CounterMetric, HistogramMetric, SetMetric, TimerMetric};
1+
use relay_statsd::{CounterMetric, GaugeMetric, SetMetric, TimerMetric};
22

33
/// Counter metrics for the Relay Cardinality Limiter.
44
pub enum CardinalityLimiterCounters {
@@ -81,7 +81,7 @@ impl TimerMetric for CardinalityLimiterTimers {
8181
}
8282
}
8383

84-
pub enum CardinalityLimiterHistograms {
84+
pub enum CardinalityLimiterGauges {
8585
/// Amount of hashes sent to Redis to check the cardinality.
8686
///
8787
/// This metric is tagged with:
@@ -96,7 +96,7 @@ pub enum CardinalityLimiterHistograms {
9696
RedisSetCardinality,
9797
}
9898

99-
impl HistogramMetric for CardinalityLimiterHistograms {
99+
impl GaugeMetric for CardinalityLimiterGauges {
100100
fn name(&self) -> &'static str {
101101
match *self {
102102
#[cfg(feature = "redis")]

0 commit comments

Comments
 (0)