Skip to content

Commit 7f0e641

Browse files
authored
fix(metrics): Bump generic extraction version (#2692)
External relays of version 23.9.1 (and possibly below) set the `metrics_extracted` flag on transaction items even if transaction metrics extraction is disabled: https://github.com/getsentry/relay/blob/ffebe6020a2a6d42fde90857868736e5769a77d2/relay-server/src/actors/processor.rs#L2099-L2104 We recently [bumped](getsentry/sentry#57759) the transaction metrics version, causing external relays to skip extraction. But because old external relays set the `metrics_extracted` flag anyway, even our internal PoPs skip metrics extraction now. This PR is a one-time fix to force old external relays to stop extracting generic metrics as well.
1 parent b368c39 commit 7f0e641

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
- Collect `http.decoded_response_content_length`. ([#2638](https://github.com/getsentry/relay/pull/2638))
2727
- Add TTID and TTFD tags to mobile spans. ([#2662](https://github.com/getsentry/relay/pull/2662))
2828
- Scrub all DB Core Data spans differently. ([#2686](https://github.com/getsentry/relay/pull/2686))
29+
- Support generic metrics extraction version 2. ([#2692](https://github.com/getsentry/relay/pull/2692))
2930

3031
## 23.10.1
3132

relay-dynamic-config/src/metrics.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,9 @@ pub struct MetricExtractionConfig {
182182

183183
impl MetricExtractionConfig {
184184
/// The latest version for this config struct.
185-
pub const VERSION: u16 = 1;
185+
///
186+
/// This is the maximum version supported by this Relay instance.
187+
pub const VERSION: u16 = 2;
186188

187189
/// Returns an empty `MetricExtractionConfig` with the latest version.
188190
///

0 commit comments

Comments
 (0)