Skip to content

Commit 588e46a

Browse files
cmanallenolksdr
andauthored
feat(replays): Enable PII scrubbing for all organizations (#1678)
#skip-changelog Co-authored-by: Oleksandr <[email protected]>
1 parent 337a8a0 commit 588e46a

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

relay-server/src/actors/processor.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ impl EnvelopeProcessorService {
10421042
ItemType::ReplayRecording => {
10431043
// XXX: Temporarily, only the Sentry org will be allowed to parse replays while
10441044
// we measure the impact of this change.
1045-
if replays_enabled && state.project_state.organization_id == Some(1) {
1045+
if replays_enabled {
10461046
// Limit expansion of recordings to the max replay size. The payload is
10471047
// decompressed temporarily and then immediately re-compressed. However, to
10481048
// limit memory pressure, we use the replay limit as a good overall limit for

tests/integration/test_replay_recordings.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import time
1+
import zlib
22

33
from sentry_sdk.envelope import Envelope, Item, PayloadRef
44

@@ -92,8 +92,6 @@ def test_chunked_replay_recordings_processing(
9292
assert replay_recording["received"]
9393
assert type(replay_recording["received"]) == int
9494

95-
outcomes_consumer.assert_empty()
96-
9795

9896
def test_nonchunked_replay_recordings_processing(
9997
mini_sentry, relay_with_processing, replay_recordings_consumer, outcomes_consumer
@@ -117,7 +115,8 @@ def test_nonchunked_replay_recordings_processing(
117115
["attachment_type", "replay_recording"],
118116
]
119117
)
120-
envelope.add_item(Item(payload=PayloadRef(bytes=b"test"), type="replay_recording"))
118+
payload = recording_payload(b"[]")
119+
envelope.add_item(Item(payload=PayloadRef(bytes=payload), type="replay_recording"))
121120

122121
relay.send_envelope(project_id, envelope)
123122

@@ -129,7 +128,12 @@ def test_nonchunked_replay_recordings_processing(
129128
assert replay_recording["org_id"] == org_id
130129
assert type(replay_recording["received"]) == int
131130
assert replay_recording["retention_days"] == 90
132-
assert replay_recording["payload"] == b"test"
131+
assert replay_recording["payload"] == payload
133132
assert replay_recording["type"] == "replay_recording_not_chunked"
134133

135134
outcomes_consumer.assert_empty()
135+
136+
137+
def recording_payload(bits: bytes):
138+
compressed_payload = zlib.compress(bits)
139+
return b'{"segment_id": 0}\n' + compressed_payload

0 commit comments

Comments
 (0)