-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#311): adds support for default date question type #328
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 75e7d93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@eyelidlessness
I'll open a separate PR for the e2e tests since we haven't merged the other PR that introduces the structure (#313) Other than that, this is ready for a review. Please have a look when you have time 🙂 |
Closes #311
Note:
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Test evidence:
Browser compatibility: Chrome, Firefox, Safari (Desktop)
Browser.compatibility.mp4
Date Notes
Note values:
<date_note>2025-12-21T23:30:05</date_note>
<date_note>2025-12-21</date_note>
Responsive and readonly
responsive.and.readonly.mp4
Allows navigating across years and months. Prevent setting invalid dates.
calendar.navigation.and.prevents.wrong.dates.mp4
Compatibility with Chrome for Android
chrome.for.android.mp4
Form's error message is closable and doesn't overlap calendar
Error.message.mp4
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
I need help testing on iPhone devices.
A test plan is in the ticket, and the test evidence is in the previous section.
What's changed
@js-temporal/polyfill
library was replaced withtemporal-polyfill
packages/xpath/src/lib/datetime/coercion.ts
to prevent out-of-range offsetsTemporal.TimeZone.from
ensures consistent rejection of out-of-spec offsets across browsers, aligning with the Temporal spec’s max of ±23:59.yyyy-mm-dd
).Note: Calendar's translation is to be resolved in this ticket: #332