refactor(java,kotlin): use updateTransportConfig lambda to configure transports (#78)

* refactor: use updateTransportConfig closure/lambda to configure transports

refactor: use updateTransportConfig closure/lambda to configure transports

* refactor: remove redundant enableAllPeerToPeer() calls

* docs: add comment why return is necessary in java

Author: phatblat

android-java/app/src/main/java/com/example/dittotasks/MainActivity.java

@@ -105,13 +105,13 @@ void initDitto() {
                             DITTO_AUTH_URL);
             ditto = new Ditto(androidDependencies, identity);
 
-            // Set the Ditto Websocket URL
-            DittoTransportConfig config = new DittoTransportConfig();
-            config.getConnect().getWebsocketUrls().add(DITTO_WEBSOCKET_URL);
+            ditto.updateTransportConfig(config -> {
+                // Set the Ditto Websocket URL
+                config.getConnect().getWebsocketUrls().add(DITTO_WEBSOCKET_URL);
 
-            // Enable all P2P transports
-            config.enableAllPeerToPeer();
-            ditto.setTransportConfig(config);
+                // lambda must return Kotlin Unit which corresponds to 'void' in Java
+                return kotlin.Unit.INSTANCE;
+            });
 
             // disable sync with v3 peers, required for DQL
             ditto.disableSyncWithV3();

android-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/TasksApplication.kt

@@ -53,14 +53,10 @@ class TasksApplication : Application() {
         )
 
         ditto = Ditto(androidDependencies, identity)
-
-        // Set the Ditto Websocket URL
-        val transportConfig = DittoTransportConfig()
-        transportConfig.connect.websocketUrls.add(webSocketURL)
-
-        // Enable all P2P transports
-        transportConfig.enableAllPeerToPeer()
-        ditto.transportConfig = transportConfig
+        ditto.updateTransportConfig { config ->
+            // Set the Ditto Websocket URL
+            config.connect.websocketUrls.add(webSocketURL)
+        }
 
         // disable sync with v3 peers, required for DQL
         ditto.disableSyncWithV3()

java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoService.java

@@ -68,18 +68,14 @@ public class DittoService implements DisposableBean {
             // disable sync with v3 peers, required for DQL
             this.ditto.disableSyncWithV3();
 
-            DittoTransportConfig transportConfig = new DittoTransportConfig.Builder()
-                    .connect(connect -> {
-                        // Set the Ditto Websocket URL
-                        connect.addWebsocketUrls(DittoSecretsConfiguration.DITTO_WEBSOCKET_URL);
-                    })
-                    .build();
-
-            logger.info("Transport config: {}", transportConfig);
-
-            this.ditto.setTransportConfig(
-                    transportConfig
-            );
+            this.ditto.updateTransportConfig(config -> {
+                config.connect(connect -> {
+                    // Set the Ditto Websocket URL
+                    connect.websocketUrls().add(DittoSecretsConfiguration.DITTO_WEBSOCKET_URL);
+                });
+
+                logger.info("Transport config: {}", config);
+            });
 
             presenceObserver = observePeersPresence();