add test infrastructure and fix lint

Author: gerkai

.eslintignore

@@ -1 +1,4 @@
+.git
+.nyc_output
+coverage
 node_modules

.gitignore

@@ -1,2 +1,4 @@
 node_modules
 npm-debug.log
+.nyc_output
+coverage

.npmignore

@@ -1,4 +1,6 @@
 *.json
 !package.json
-!test
-!.git
+test
+.git
+.nyc_output
+coverage

lib/auth.js

@@ -44,7 +44,7 @@ async function auth() {
   await writeFile(authFile, json, { mode:
     0o600 /* owner read/write */
   });
-  return await auth();
+  return auth();
 }
 
 async function prompt(question) {
@@ -66,7 +66,10 @@ async function prompt(question) {
 function lazy(fn) {
   let cachedValue;
   return function() {
-    if (cachedValue !== undefined) { return cachedValue; }
-    return cachedValue = fn();
+    if (cachedValue !== undefined) {
+      return cachedValue;
+    }
+    cachedValue = fn();
+    return cachedValue;
   };
 }

lib/request.js

@@ -35,7 +35,6 @@ async function request(query, variables) {
 async function requestAll(query, variables, path) {
   let after = null;
   let all = [];
-  let totalCount;
   // first page
   do {
     const varWithPage = Object.assign({
@@ -51,7 +50,6 @@ async function requestAll(query, variables, path) {
     //   pageInfo { hasNextPage, endCursor }
     //   nodes
     all = all.concat(current.nodes);
-    totalCount = current.totalCount;
     if (current.pageInfo.hasNextPage) {
       after = current.pageInfo.endCursor;
     } else {

package.json

@@ -7,7 +7,11 @@
     "get-metadata": "./bin/metadata.js"
   },
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
+    "test": "npm run test-unit && npm run lint",
+    "test-unit": "mocha --require intelli-espower-loader test/unit/*.test.js",
+    "test-all": "mocha --require intelli-espower-loader test/**/*.test.js",
+    "coverage": "nyc npm test",
+    "coverage-all": "nyc npm run test-all",
     "lint": "eslint ."
   },
   "author": "Joyee Cheung <joyeec9h3@gmail.com>",
@@ -25,6 +29,10 @@
     "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-node": "^5.2.1",
     "eslint-plugin-promise": "^3.6.0",
-    "eslint-plugin-standard": "^3.0.1"
+    "eslint-plugin-standard": "^3.0.1",
+    "intelli-espower-loader": "^1.0.1",
+    "mocha": "^4.0.1",
+    "nyc": "^11.2.1",
+    "power-assert": "^1.4.4"
   }
 }

test/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "env": {
+    "node": true,
+    "mocha": true
+  }
+}

test/fixtures/comments_with_ci.json

@@ -0,0 +1,22 @@
+[
+  {
+    "publishedAt": "2017-10-27T04:16:36.458Z",
+    "bodyText": "CI: https://ci.nodejs.org/job/node-test-pull-request/10984/\ncitgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1030/"
+  },
+  {
+    "publishedAt": "2017-10-24T04:16:36.458Z",
+    "bodyText": "https://ci.nodejs.org/view/libuv/job/libuv-test-commit/537/"
+  },
+  {
+    "publishedAt": "2017-10-23T04:16:36.458Z",
+    "bodyText": "https://ci.nodejs.org/job/node-test-commit-linux-nointl/7"
+  },
+  {
+    "publishedAt": "2017-10-22T04:16:36.458Z",
+    "bodyText": "CI: https://ci.nodejs.org/job/node-test-pull-request/10992/\nV8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1018/"
+  },
+  {
+    "publishedAt": "2017-10-21T04:16:36.458Z",
+    "bodyText": "Oh nice, it's back now. Benchmark CI: https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/20/"
+  }
+]

test/fixtures/index.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+exports.readFile = function(filePath) {
+  const file = path.resolve(__dirname, filePath);
+  return fs.readFileSync(file, 'utf8');
+};
+
+exports.readJSON = function(filePath) {
+  const file = exports.readFile(filePath);
+  return JSON.parse(file);
+};

test/fixtures/op_html.json

@@ -0,0 +1,4 @@
+[
+  "<p>The npm install rules had a hidden dependency on the <code>node</code> binary<br>\ninstall rule creating the <code>$PREFIX/bin</code> directory.</p>\n<p>Because with <code>./configure --shared</code> no binary is created, the rule<br>\nsubsequently failed.  Fix that by creating the directory before<br>\ncreating the symlinks to the npm and npx scripts.</p>\n<p>(Whether it makes sense to install npm without a <code>node</code> binary is<br>\na separate question.  This commit is not taking positions. :-))</p>\n<p>Regression introduced in commit <a href=\"https://github.com/nodejs/node/commit/ed8c89a07d159b72a2e351a76c92b8b6a15515bd\" class=\"commit-link\"><tt>ed8c89a</tt></a> (\"build: fix shared installing<br>\ntarget\") which, as the commit log indicates, was itself a bug fix for<br>\nthe <code>./configure --shared</code> install.</p>\n<p>Fixes: <a href=\"https://github.com/nodejs/node/issues/16437\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"267969588\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16437\">#16437</a><br>\nRefs: <a href=\"https://github.com/nodejs/node/pull/15148\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"254809069\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/15148\">#15148</a></p>",
+  "<p>Refs: <a href=\"https://github.com/nodejs/node/pull/16293\" class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"266519190\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/nodejs/node/issues/16293\">#16293</a></p>\n<h5>Checklist</h5>\n\n<ul class=\"contains-task-list\">\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> <code>make -j4 test</code> (UNIX), or <code>vcbuild test</code> (Windows) passes</li>\n<li class=\"task-list-item\"><input checked=\"\" class=\"task-list-item-checkbox\" disabled=\"\" id=\"\" type=\"checkbox\"> commit message follows <a href=\"https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines\">commit guidelines</a></li>\n</ul>\n<h5>Affected core subsystem(s)</h5>\n\n<p>vm</p>"
+]

test/unit/ci.test.js

@@ -0,0 +1,40 @@
+'use strict';
+
+const CIParser = require('../../lib/ci');
+const fixtures = require('../fixtures');
+const assert = require('assert');
+const comments = fixtures.readJSON('comments_with_ci.json');
+
+const expected = new Map([
+  ['FULL', {
+    link: 'https://ci.nodejs.org/job/node-test-pull-request/10984/',
+    date: '2017-10-27T04:16:36.458Z'
+  }],
+  ['CITGM', {
+    link: 'https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1030/',
+    date: '2017-10-27T04:16:36.458Z'
+  }],
+  ['LIBUV', {
+    link: 'https://ci.nodejs.org/view/libuv/job/libuv-test-commit/537/',
+    date: '2017-10-24T04:16:36.458Z'
+  }],
+  ['NOINTL', {
+    link: 'https://ci.nodejs.org/job/node-test-commit-linux-nointl/7',
+    date: '2017-10-23T04:16:36.458Z'
+  }],
+  ['V8', {
+    link: 'https://ci.nodejs.org/job/node-test-commit-v8-linux/1018/',
+    date: '2017-10-22T04:16:36.458Z'
+  }],
+  ['BENCHMARK', {
+    link: 'https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/20/',
+    date: '2017-10-21T04:16:36.458Z'
+  }]
+]);
+
+describe('CIparser', () => {
+  it('should parse CI results', () => {
+    const results = new CIParser(comments).parse();
+    assert.deepStrictEqual(expected, results);
+  });
+});

test/unit/links.test.js

@@ -0,0 +1,28 @@
+'use strict';
+
+const LinkParser = require('../../lib/links');
+const fixtures = require('../fixtures');
+const assert = require('assert');
+const htmls = fixtures.readJSON('op_html.json');
+
+const expected = [{
+  fixes: ['https://github.com/node/issues/16437'],
+  refs: ['https://github.com/nodejs/node/pull/15148']
+}, {
+  fixes: [],
+  refs: ['https://github.com/nodejs/node/pull/16293']
+}];
+
+describe('CIparser', () => {
+  it('should parse CI results', () => {
+    for (let i = 0; i < htmls.length; ++i) {
+      const op = htmls[i];
+      const parser = new LinkParser('node', op);
+      const actual = {
+        fixes: parser.getFixes(),
+        refs: parser.getRefs()
+      };
+      assert.deepStrictEqual(actual, expected[i]);
+    }
+  });
+});