git-node: add core-validate-commit to dependencies

This removes an install step by directly depending on the dependency
instead of asking the user to install it separately.

Fixes: nodejs/node-core-utils#177

Author: gerkai

docs/git-node.md

@@ -6,21 +6,16 @@ A custom Git command for managing pull requests. You can run it as
 ### Prerequistes
 
 1. It's a Git command, so make sure you have Git installed, of course.
-2. Install [core-validate-commit](https://github.com/nodejs/core-validate-commit)
-
-    ```
-    $ npm install -g core-validate-commit
-    ```
-3. Configure your upstream remote and branch name. By default it assumes your
-  remote pointing to https://github.com/nodejs/node is called `upstream`, and
-  the branch that you are trying to land PRs on is `master`. If that's not the
-  case:
-
-    ```
-    $ cd path/to/node/project
-    $ ncu-config set upstream your-remote-name
-    $ ncu-config set branch your-branch-name
-    ```
+1. Configure your upstream remote and branch name. By default it assumes your
+   remote pointing to https://github.com/nodejs/node is called `upstream`, and
+   the branch that you are trying to land PRs on is `master`. If that's not the
+   case:
+
+   ```
+   $ cd path/to/node/project
+   $ ncu-config set upstream your-remote-name
+   $ ncu-config set branch your-branch-name
+   ```
 
 ### Demo & Usage
 

lib/landing_session.js

@@ -159,7 +159,7 @@ class LandingSession extends Session {
     const branch = this.branch;
     const notYetPushed = this.getNotYetPushedCommits();
     const notYetPushedVerbose = this.getNotYetPushedCommits(true);
-    await runAsync('core-validate-commit', notYetPushed);
+    await runAsync('npx', ['core-validate-commit', ...notYetPushed]);
 
     cli.separator();
     cli.log('The following commits are ready to be pushed to ' +

package-lock.json

@@ -32,6 +32,7 @@
   "license": "MIT",
   "dependencies": {
     "chalk": "^2.2.0",
+    "core-validate-commit": "^3.5.0",
     "figures": "^2.0.0",
     "ghauth": "^3.2.1",
     "jsdom": "^11.3.0",