Skip to content

Commit fe16965

Browse files
authored
[6.0.0] Default --incompatible_strict_conflict_checks to true. (bazelbuild#16864)
The downstream pipeline indicates that this is safe to flip: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1346 Fixes bazelbuild#16729. RELNOTES[INC]: `--incompatible_strict_conflict_checks` is flipped to true. See bazelbuild#16729 for details. PiperOrigin-RevId: 491324038 Change-Id: Iea8951867fa20f2aa1a67bf3ba3c86c26e4292de
1 parent 29669e6 commit fe16965

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@ public class AnalysisOptions extends OptionsBase {
9191
public boolean skyframePrepareAnalysis;
9292

9393
@Option(
94-
name = "experimental_strict_conflict_checks",
95-
defaultValue = "false",
94+
name = "incompatible_strict_conflict_checks",
95+
oldName = "experimental_strict_conflict_checks",
96+
defaultValue = "true",
9697
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
9798
metadataTags = OptionMetadataTag.INCOMPATIBLE_CHANGE,
9899
effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION},

src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java

+4
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,8 @@ public void symlinkToDirectory() throws Exception {
312312

313313
@Test
314314
public void symlinkToNestedFile() throws Exception {
315+
addOptions("--noincompatible_strict_conflict_checks");
316+
315317
write(
316318
"a/defs.bzl",
317319
"def _impl(ctx):",
@@ -364,6 +366,8 @@ public void symlinkToNestedFile() throws Exception {
364366

365367
@Test
366368
public void symlinkToNestedDirectory() throws Exception {
369+
addOptions("--noincompatible_strict_conflict_checks");
370+
367371
write(
368372
"a/defs.bzl",
369373
"def _impl(ctx):",

0 commit comments

Comments
 (0)