Skip to content

Commit 5ddef47

Browse files
authored
Turn applicable_licenses on platform() into a no-op. (bazelbuild#18089)
This prevents an analysis loop where default_applicable_licenses applies a license to a platform, but then the same license rule depends on the platform. Backport of Ic12306f5a405c88bd65acf3b8ec419328ce663f3
1 parent 1474b5b commit 5ddef47

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/main/java/com/google/devtools/build/lib/rules/platform/PlatformBaseRule.java

+8
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.devtools.build.lib.analysis.PlatformConfiguration;
2222
import com.google.devtools.build.lib.analysis.RuleDefinition;
2323
import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment;
24+
import com.google.devtools.build.lib.packages.BuildType;
2425
import com.google.devtools.build.lib.packages.RuleClass;
2526
import com.google.devtools.build.lib.packages.RuleClass.ToolchainResolutionMode;
2627
import com.google.devtools.build.lib.packages.Type;
@@ -41,6 +42,13 @@ public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env)
4142
// No need to show up in ":all", etc. target patterns.
4243
.value(ImmutableList.of("manual"))
4344
.nonconfigurable("low-level attribute, used in platform configuration"))
45+
.override(
46+
// A platform is essentially a constant which is never linked into a target.
47+
// This will, in a very hacky way, suppress picking up default_applicable_licenses
48+
attr("applicable_licenses", BuildType.LABEL_LIST)
49+
.value(ImmutableList.of())
50+
.allowedFileTypes()
51+
.nonconfigurable("fundamental constant, used in platform configuration"))
4452
.exemptFromConstraintChecking("this rule helps *define* a constraint")
4553
.useToolchainResolution(ToolchainResolutionMode.DISABLED)
4654
.removeAttribute("deps")

0 commit comments

Comments
 (0)