Skip to content

Commit 43dadb2

Browse files
illicitonioncopybara-github
authored andcommitted
Bump minimum supported macOS versions to 10.13
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes bazelbuild#17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc
1 parent e218924 commit 43dadb2

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

scripts/bootstrap/compile.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ cp $OUTPUT_DIR/libblaze.jar ${ARCHIVE_DIR}
415415
# TODO(b/28965185): Remove when xcode-locator is no longer required in embedded_binaries.
416416
log "Compiling xcode-locator..."
417417
if [[ $PLATFORM == "darwin" ]]; then
418-
run /usr/bin/xcrun --sdk macosx clang -mmacosx-version-min=10.9 -fobjc-arc -framework CoreServices -framework Foundation -o ${ARCHIVE_DIR}/xcode-locator tools/osx/xcode_locator.m
418+
run /usr/bin/xcrun --sdk macosx clang -mmacosx-version-min=10.13 -fobjc-arc -framework CoreServices -framework Foundation -o ${ARCHIVE_DIR}/xcode-locator tools/osx/xcode_locator.m
419419
else
420420
cp tools/osx/xcode_locator_stub.sh ${ARCHIVE_DIR}/xcode-locator
421421
fi

tools/cpp/osx_cc_configure.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def _compile_cc_file_single_arch(repository_ctx, src_name, out_name, timeout):
6868
"--sdk",
6969
"macosx",
7070
"clang",
71-
"-mmacosx-version-min=10.9",
71+
"-mmacosx-version-min=10.13",
7272
"-std=c++11",
7373
"-lc++",
7474
"-O3",
@@ -98,7 +98,7 @@ def _compile_cc_file(repository_ctx, src_name, out_name, timeout):
9898
"--sdk",
9999
"macosx",
100100
"clang",
101-
"-mmacosx-version-min=10.9",
101+
"-mmacosx-version-min=10.13",
102102
"-std=c++11",
103103
"-lc++",
104104
"-arch",

tools/osx/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ exports_files([
2828
])
2929

3030
DARWIN_XCODE_LOCATOR_COMPILE_COMMAND = """
31-
/usr/bin/xcrun --sdk macosx clang -mmacosx-version-min=10.9 -fobjc-arc -framework CoreServices \
31+
/usr/bin/xcrun --sdk macosx clang -mmacosx-version-min=10.13 -fobjc-arc -framework CoreServices \
3232
-framework Foundation -arch arm64 -arch x86_64 -Wl,-no_adhoc_codesign -Wl,-no_uuid -o $@ $< && \
3333
env -i codesign --identifier $@ --force --sign - $@
3434
"""

tools/osx/xcode_configure.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def run_xcode_locator(repository_ctx, xcode_locator_src_label):
131131
"--sdk",
132132
"macosx",
133133
"clang",
134-
"-mmacosx-version-min=10.9",
134+
"-mmacosx-version-min=10.13",
135135
"-fobjc-arc",
136136
"-framework",
137137
"CoreServices",

0 commit comments

Comments
 (0)