Add missing 'MultilineBracketStyle' in the returned configuration JSON #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangelMaxime
force-pushed
the
fix-daemon-configuration
branch
from
dcb0a54 to
cd5ec41
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Could you remind me what this is about? Is this about |
|
Yes, this is so an external process like FSAC/Ionide could request the list of settings supported by Fantomas. This is needed in order to create an integration in VSCode to verify For example, this is how Fantomas tool generate the options interface, so if a setting is missing the interface would be incomplete. Note: Fantomas tool use another way to get the options list so it is not impacted by this bug |
MangelMaxime
force-pushed
the
fix-daemon-configuration
branch
from
bdc2ce3 to
fe8d18d
Compare
nojaf
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify your pull request is respecting our Pull request ground rules.
You can find more information in our Contributors documentation section.