Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems upgrading gems #2450

Open
ojeytonwilliams opened this issue Mar 4, 2025 · 0 comments
Open

Problems upgrading gems #2450

ojeytonwilliams opened this issue Mar 4, 2025 · 0 comments

Comments

@ojeytonwilliams
Copy link
Contributor

As it stands several key gems cannot be upgraded because of version conflicts. Specifically, v4 of sinatra depends on rack (>= 3, < 4) and that conflicts with sprockets-sass. This is because DevDocs depends on sprockets-sass, but the latest version of that is only compatible with sprockets < 4 and finally sprockets 3.75 (the highest version compatible with sprockets-sass) requires rack <3.

In short, we can't upgrade sinatra or rack because there's no compatible version of sprockets-sass and that's unmaintained at this point.

What sprocket-sass is doing

It enables @import statements to work in .scss files, including when the imported file is an ERB that in turn compiles to SCSS (that compiles to CSS). The main place this happens is
https://github.com/freeCodeCamp/devdocs/blob/2c5b5bd25985101fa2f06c28bb9bae15d821bfbc/assets/stylesheets/application.css.scss

What can be done

I see two potential paths forward

  1. Fork sprockets-sass and make it compatible with sprockets 4 (and Ruby 3)
  2. Inline the imports and convert application.css.scss to application.css.scss.erb, which should work since the issue sprockets-sass solved was specifically @importing files, not compiling .erb files.

I'm not sure how long 1. would take. I looked into it, but I didn't make much headway.

Option 2. would be ugly, but not awful. Reason being, the imported files are not used more than once, so the code wouldn't get any less DRY. We would end up with one massive file, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant