Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still tons of references to params in task files, even after we've flattened the task JSON #7

Open
dzwillia opened this issue May 10, 2018 · 1 comment
Assignees

Comments

@dzwillia
Copy link
Member

dzwillia commented May 10, 2018

Just do a search on 'params' in the flexio-sdk-js repo. Results are everywhere.

Any call to _.get(json, 'params', json) has got to go -- there's no need to use _.get() in any of these scenarios anymore since we've flattened the JSON. The json parameter that is passed in does need to be deep cloned, however, if it is going to be mutated at all.

I've attached a file with all of the references I could find to 'params' in the task files.

params-in-task-files.txt

@biwillia
Copy link
Member

This is by design. It will go, but it's meant to be temporarily backward-compatible with the old format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants