Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream review of sandboxing code? #43

Closed
cjao opened this issue Dec 19, 2020 · 2 comments
Closed

Upstream review of sandboxing code? #43

cjao opened this issue Dec 19, 2020 · 2 comments

Comments

@cjao
Copy link

cjao commented Dec 19, 2020

First of all, thanks for your work in packaging this! I notice that you have written a patch to adapt Chromium to Flatpak's sandbox. Are you planning to submit this upstream for review? I appreciate your work in building this package, but it's really important to not compromise the quality of the sandbox.

@Erick555
Copy link
Contributor

AFAIK upstream stated they aren't interested in adopting flatpak sandbox support atm.

@refi64
Copy link
Collaborator

refi64 commented Dec 20, 2020

Indeed at least for now, there is no interest in another sandbox, and I doubt the current global situation would do much to encourage this given that the Chromium team is probably still WFH.

That being said, it's worth noting Chromium's sandbox is two layers, the second being a rather strict BPF sandbox, and that one is entirely unmodified. The first layer is primarily to block filesystem access, which has been tested and confirmed to work here (partly because we've had files end up missing that we needed to be able to access 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants