Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard-xml-derive: create an upstream pull request for with attribute #35

Open
dongsupark opened this issue Nov 27, 2023 · 4 comments
Open

hard-xml-derive: create an upstream pull request for with attribute #35

dongsupark opened this issue Nov 27, 2023 · 4 comments
Assignees
@dongsupark
Labels
kind/feature A feature request.

Comments

@dongsupark
Copy link
Member

ue-rs has several 3rd-party patches under vendor/hard-xml-derive to add with attributes.

Ideally the changes should be created as an upstream pull request of the upstream repo.
@dongsupark dongsupark added the kind/feature A feature request. label Nov 27, 2023
@dongsupark dongsupark self-assigned this Dec 11, 2023
@dongsupark
Copy link
Member Author

Created an upstream PR https://gitlab.com/kevincox/hard-xml/-/merge_requests/13.

@github-actions github-actions bot mentioned this issue Dec 22, 2023
Closed
@dongsupark
Copy link
Member Author

The upstream PR https://gitlab.com/kevincox/hard-xml/-/merge_requests/13 was merged, and included in hard-xml v1.34.0. We need to also update the corresponding ue-rs code.

@pothos
Copy link
Member

pothos commented Jan 16, 2024

Should we open a new issue for the remaining task?

@dongsupark
Copy link
Member Author

Right, sorry, I still have to get back to the rest work.

@dongsupark dongsupark reopened this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongsupark dongsupark

Labels
kind/feature A feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pothos @dongsupark