tests(github) add lint and bump nginx 1.21.4 (#83)

Author: fffonion

.github/workflows/lint.yml

@@ -0,0 +1,32 @@
+name: Lint
+
+on:
+  push:
+    paths:
+      - lib/**.lua
+  pull_request:
+    paths:
+      - lib/**.lua
+
+jobs:
+  tests:
+    name: Lint
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Checkout source code
+      uses: actions/checkout@v2
+    - uses: Jayrgo/luacheck-action@v1
+      name: luacheck
+      with:
+        # List of files, directories and rockspecs to check.
+        # Default: .
+        files: 'lib'
+
+        # Path to configuration file.
+        # Default: .luacheckrc
+        config: '.luacheckrc'
+
+        # Arguments passed to luacheck.
+        # Default: -q
+        args: '-q'

.github/workflows/tests.yml

@@ -14,26 +14,21 @@ jobs:
     strategy:
       matrix:
         include:
+        - nginx: "1.21.4"
+          openssl: "1.1.1q"
+          lua_nginx_module: "v0.10.21"
+          stream_lua_nginx_module: "v0.0.11"
+          lua_resty_core: "v0.1.23"
         - nginx: "1.19.9"
-          openssl: "1.1.1k"
-          lua_nginx_module: "v0.10.20"
-          stream_lua_nginx_module: "v0.0.10"
-          lua_resty_core: "v0.1.22"
-        - nginx: "1.19.9"
-          openssl: "1.0.2u"
+          openssl: "1.1.1q"
           lua_nginx_module: "v0.10.20"
           stream_lua_nginx_module: "v0.0.10"
           lua_resty_core: "v0.1.22"
         - nginx: "1.19.3"
-          openssl: "1.1.1k"
+          openssl: "1.1.1q"
           lua_nginx_module: "v0.10.19"
           stream_lua_nginx_module: "v0.0.9"
           lua_resty_core: "v0.1.21"
-        - nginx: "1.17.8"
-          openssl: "1.1.1k"
-          lua_nginx_module: "v0.10.17"
-          stream_lua_nginx_module: "v0.0.8"
-          lua_resty_core: "v0.1.19"
 
     env:
       JOBS: 3

.luacheckrc

@@ -0,0 +1,15 @@
+std             = "ngx_lua"
+unused_args     = false
+redefined       = false
+max_line_length = false
+
+
+not_globals = {
+    "string.len",
+    "table.getn",
+}
+
+
+ignore = {
+    "6.", -- ignore whitespace warnings
+}

lib/resty/acme/client.lua

@@ -475,16 +475,12 @@ function _M:finalize(finalize_url, order_url, csr)
     csr = encode_base64url(csr)
   }
 
-  local resp, headers, err = self:post(finalize_url, payload)
+  local resp, _, err = self:post(finalize_url, payload)
 
   if err then
     return nil, "failed to send finalize request: " .. err
   end
 
-  if not headers["content-type"] == "application/pem-certificate-chain" then
-    return nil, "wrong content type"
-  end
-
   -- Wait until the order is valid: ready to download
   if not resp.certificate and resp.status and resp.status == "valid" then
     log(ngx_DEBUG, json.encode(resp))
@@ -502,6 +498,11 @@ function _M:finalize(finalize_url, order_url, csr)
     return nil, "failed to fetch certificate: " .. err
   end
 
+  local cert_content_type = headers["content-type"]
+  if cert_content_type and string.sub(cert_content_type, 1, 33):lower() ~= "application/pem-certificate-chain" then
+    return nil, "wrong content type, got " .. cert_content_type
+  end
+
   local preferred_chain = self.conf.preferred_chain
   if not preferred_chain then
     return body