Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with latest moment-range #74

Open
tabby-or-not opened this issue Jul 20, 2018 · 1 comment
Open

Incompatible with latest moment-range #74

tabby-or-not opened this issue Jul 20, 2018 · 1 comment

Comments

@tabby-or-not
Copy link

tabby-or-not commented Jul 20, 2018

react-kronos appears to be incompatible with the latest version of moment-range - crashing with a Type Error: range is not a function

I believe the error is coming from https://github.com/dubert/react-kronos/blob/10eab390ee66af45fad324bd4c7bdbf61175c45a/src/calendar.js#L109

The new syntax for moment-range is

import Moment from 'moment'
import { extendMoment } from 'moment-range'

const moment = extendMoment(Moment)

I have fixed moment-range to v2.2.0 in our project as a temporary fix.

@felixakiragreen
Copy link
Owner

Thanks for bringing this up! Should be able to fix it pretty quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants