Skip to content

Updating Files Does not Cause HMR Reload #659

Closed
@danielstern

Description

@danielstern

I'm working in an application with lots of nested directories and .js files.

Sometimes, after I modify and save the file, it simply... does not update or rebuild. I have to stop the process and restart it.

What's the solution to this?

Activity

tbillington

tbillington commented on Sep 16, 2016

@tbillington

I had this issue when working with a project that was in a dropbox folder. Hasn't affected any of my projects were outside the folder though.

ippa

ippa commented on Sep 16, 2016

@ippa

Not exactly the same, but feels related: Sometimes saving a js-file doesn't trigger the livereload. When I save it a second time it works. Sorry for the lack of details, but happens every now and then and I haven't been able to pinpoint the cause. On windows 10, latest CRA, editing with vim in gitbash.

cpeele00

cpeele00 commented on Sep 16, 2016

@cpeele00

Same here. In fact I have a very simple project with no nested directories and the rebuilding/reloading is spotty at best. It will just stop rebuilding and hot-reloading so I am continuously having to stop the process and start it all over again. IMHO this is the biggest impedance to a smooth development experience with CreateReactApp. You guys have done such an amazing job thus far, if you could just get this and css preprocessors working you will have nailed it! Keep up the good work!

gaearon

gaearon commented on Sep 16, 2016

@gaearon
Contributor

Can you reproduce this with a freshly created app, or only in existing apps?
Has this been always happening, or just recently?
Could you please share your system versions?

SpaceK33z

SpaceK33z commented on Sep 17, 2016

@SpaceK33z
Contributor

This could be related to the "safe write" feature some editors use. See "Working with editors/IDEs supporting safe write" from the webpack-dev-server docs.

If this fixes it, and I think it will because I've seen dozens of issues in WDS because of this, I'd suggest to very clearly document this somewhere in CRA :).

gaearon

gaearon commented on Sep 17, 2016

@gaearon
Contributor

@SpaceK33z

Thanks for jumping in. I totally forgot about it.

@danielstern @tbillington @ippa @cpeele00

Does this help?

cpeele00

cpeele00 commented on Sep 18, 2016

@cpeele00

@gaearon I'll give it a shot and will get back to you. Thanks!

ippa

ippa commented on Sep 18, 2016

@ippa

@SpaceK33z: that url seems broken? it doesn't jump to any specific part of the page and I can't even find the word "safe".

gaearon

gaearon commented on Sep 18, 2016

@gaearon
Contributor

It didn't show up for me at first but I saw it after refresh.

screen shot 2016-09-18 at 14 41 39

SpaceK33z

SpaceK33z commented on Sep 18, 2016

@SpaceK33z
Contributor

@ippa, apparently some dude renamed the whole wiki page for webpack-dev-server to "react-hot", causing some weird issues :(. I renamed it back now, so it should work again.

@gaearon haha see your comment just popping up, see above ;p.

GramParallelo

GramParallelo commented on Sep 19, 2016

@GramParallelo

I have a fresh install of create-react-app on Debian 8.5 using text editor Atom and Chrome for browser. When I change App.js and save the reloading is not happening. Any ideas?

gaearon

gaearon commented on Sep 19, 2016

@gaearon
Contributor
danielstern

danielstern commented on Sep 20, 2016

@danielstern
Author

@gaearon Absolutely, I was using IntelliJ. It turns out, the Safe Write feature was causing this.Is there some kind of universal editor_config setting that could disable this in editors?

45 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ippa@merlinstardust@elynde@AJamesPhillips@SpaceK33z

        Issue actions

          Updating Files Does not Cause HMR Reload · Issue #659 · facebook/create-react-app