Auto-detect more common editors

[gaearon]

Let's send PRs for autodetecting more common editors for the error overlay!
The feature already works both on macOS and Windows (thanks @levrik).

Currently detected editors are here:

const COMMON_EDITORS_OSX = {
  '/Applications/Atom.app/Contents/MacOS/Atom': 'atom',
  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',
  '/Applications/Sublime Text.app/Contents/MacOS/Sublime Text': '/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl',
  '/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2': '/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl',
  '/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code',
};

const COMMON_EDITORS_WIN = [
  'Code.exe',
  'atom.exe',
  'sublime_text.exe',
  'notepad++.exe',
];

If your favorite editor isn't in the list, but supports running from the command line with a line number, send a PR to launchEditor.js adding it to the list, and specifying its argument format.

To verify your change works, edit node_modules/react-dev-utils/launchEditor.js in your project, add a throw new Error('hi') to a component, and then verify that clicking on the error overlay takes you to the right place.

[jantimon]

This feature is really cool - you should create an independent npm package out of that! 👍

[gaearon]

Agree, we should extract it at some point! It's originally forked from React Native but we added more features and might eventually make RN depend on it.

[ntucker]

why no linux? :(

[gaearon]

@ntucker Because nobody contributed Linux support yet. Would you like to do that?

[miraage]

In my opninion, WebStorm,PhpStorm and Idea should also be there. Despite the fact that JetBrains IDEs are offering to create a shortcut, still not a lot of people do it.

[gaearon]

Happy to take PRs!

[bunshar]

@gaearon I would like to contributed Linux support. Should I create another ticket?

[gaearon]

@bunshar This ticket is fine—just send a PR!

[reznord]

@gaearon in OSX you can launch Atom Beta using atom-beta command.

So,

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',

can be

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': 'atom-beta',

[gaearon]

Happy to take PRs (although if it works fine, I wouldn't change it).

[reznord]

Can I take this up and add Linux support as well?

Sent from my OnePlus ONEPLUS A3003 using FastHub

[gaearon]

Sure.