Skip to content

PWA / Service worker breaking production deployments #2440

New issue
New issue
Closed
Closed
PWA / Service worker breaking production deployments#2440
Labels
issue: question > PWA
@ro-savage

Description

@ro-savage
ro-savage
opened on Jun 1, 2017 · edited by ro-savage
Contributor

EDIT: Issue appears to be with Firebase only

Service workers aren't refreshing index.html and therefore new deploys are showing old bundles.

This means production websites or really all deployed sites that use a single url/domain can not be updated.

PR #2441 - Is a hotfix (if needed) that just removes the service worker and updates docs to say they have been disabled temporarily.

@gaearon @Timer @jeffposnick @addyosmani

Steps to reproduce

  • create-react-app sw-test
  • cd sw-test
  • npm install
  • npm run build
  • cd build

Deploy with firebase

  • firebase deploy
  • Visit site https://[project].firebaseapp.com. Confirm working.
  • Change app.js
  • npm run build
  • cd build
  • deploy firebase

Check website

  • Visit site again and no changes shown. DevTools shows SW is providing index.html and old bundles.
  • Force refresh a few times. No difference.
  • Delete service worker.
  • Refresh.
  • See correctly updated site.

Can someone else confirm this is affecting them?

I am hoping I am doing something wrong and this isn't affecting every production deploy.

Activity

ro-savage

ro-savage commented on Jun 1, 2017

@ro-savage
ro-savage
on Jun 1, 2017
ContributorAuthor

Additionally, you can not remove the service worker because if you try to unregister in a new deploy, the user will never see the updated bundle.

ro-savage
mentioned this on Jun 1, 2017
gaearon

gaearon commented on Jun 1, 2017

@gaearon
gaearon
on Jun 1, 2017
Contributor

cc @jeffposnick

ro-savage
changed the title [-]CRITICAL: PWA / Service worker not refreshing on deployment in production[/-] [+]CRITICAL: PWA / Service worker breaking production deployments[/+] on Jun 1, 2017
bunshar

bunshar commented on Jun 1, 2017

@bunshar
bunshar
on Jun 1, 2017
Contributor

Looks like something to do with "now". Works for me - Checked with "surge" and localhost

gaearon

gaearon commented on Jun 1, 2017

@gaearon
gaearon
on Jun 1, 2017
Contributor

cc @rauchg

ro-savage

ro-savage commented on Jun 1, 2017

@ro-savage
ro-savage
on Jun 1, 2017 · edited by ro-savage
ContributorAuthor

Thank you @bunshar !

I tried surge on a new project built from scratch. And it working as expected.

Deployed same app on now and its working as expected.

No idea what happened or what I did different.

Happy to close this and assume I managed to screw something up multiple times and over-react.

I will keep an eye on my projects and see if I can narrow down what happened.

ro-savage
closed this as completedon Jun 1, 2017
ro-savage
changed the title [-]CRITICAL: PWA / Service worker breaking production deployments[/-] [+]PWA / Service worker breaking production deployments[/+] on Jun 1, 2017
ro-savage

ro-savage commented on Jun 1, 2017

@ro-savage
ro-savage
on Jun 1, 2017
ContributorAuthor

Still running into issues on firebase.

Deploying same newly create app to now, surge and firebase.

now and surge are updating. firebase is not. (newly created project: https://cra-sw.firebaseapp.com/)

Will see if its working tomorrow and will contact firebase and see what they say.

ro-savage

ro-savage commented on Jun 1, 2017

@ro-savage
ro-savage
on Jun 1, 2017 · edited by ro-savage
ContributorAuthor

Just to prove I am not crazy and this is a thing on firebase.

Deploying changes with serve, now, surge and firebase.
Approximately 3 minutes
https://www.youtube.com/watch?v=oYy-WqkgS1Q

gaearon
reopened this on Jun 1, 2017
gaearon

gaearon commented on Jun 1, 2017

@gaearon
gaearon
on Jun 1, 2017
Contributor

Let’s keep it open and wait for @jeffposnick to help with diagnosing this.

gaearon
added
issue: question > PWA
on Jun 1, 2017

11 remaining items

Andersos
added a commit that references this issue on Nov 18, 2017

Don't cache service worker ref facebook/create-react-app#2440

2c1f037
bobrosoft
mentioned this on Dec 29, 2017
gaearon

gaearon commented on Jan 8, 2018

@gaearon
gaearon
on Jan 8, 2018
Contributor

Closing in favor of #2398.

gaearon
closed this as completedon Jan 8, 2018
jeffposnick
mentioned this in 2 issues on Jan 12, 2018
lusan

lusan commented on Feb 1, 2018

@lusan
lusan
on Feb 1, 2018

Hi everyone, sorry for asking a similar question in a closed issue, thought it is related to it and the solution might be simple.

I am trying to set cache header for sw with nginx, in the configuration like it has been done in firebase, I tried

location /service-worker.js {
    add_header Cache-Control "no-cache";
    proxy_cache_bypass $http_pragma;
    proxy_cache_revalidate on;
    expires off;
    access_log off;
}

However when I load my page, sw registration fails with the message.

A bad HTTP response code (404) was received when fetching the script. registerServiceWorker.js:71 Error during service worker registration: TypeError: Failed to register a ServiceWorker: A bad HTTP response code (404) was received when fetching the script.

@gaearon @Timer @jeffposnick @addyosmani @mbleigh

Can someone please help me with this?

BlakeWilliams
added a commit that references this issue on Feb 13, 2018

Don't cache service worker file

af8127a
BlakeWilliams
mentioned this on Feb 13, 2018
cloudlena
mentioned this on Feb 15, 2018
r17x
mentioned this on Apr 3, 2018
TheMen4ce
added a commit that references this issue on Apr 20, 2018

prevent service worker from caching and therefore not updating site. …

002ed37
vonkanehoffen
added a commit that references this issue on Nov 11, 2018

Fix blank page SW deploy. See facebook/create-react-app#2440

b3d8853
j-lee8

j-lee8 commented on Jan 13, 2019

@j-lee8
j-lee8
on Jan 13, 2019

Is anybody still experiencing this issue? I've just created an app via create-react-app and deployed it to Firebase but when I check the Network and Application tabs in dev tools the service worker isn't there? When I do a local serve -s build it runs perfectly, but it doesn't appear to be loaded through Firebase.

Doing a Lighthouse audit it says there is no service worker on the page, yet inside the build dir the service-worker.js is there and it's also inside the asset-manifest.json.

Thanks all!

lock
locked and limited conversation to collaborators on Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue: question > PWA

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mbleigh@addyosmani@gaearon@jeffposnick@antmarot

        Issue actions
          PWA / Service worker breaking production deployments · Issue #2440 · facebook/create-react-app