Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderToReadableStream Passes Reusable Chunks #24032

Closed
sebmarkbage opened this issue Mar 4, 2022 · 0 comments · Fixed by #24034
Closed

renderToReadableStream Passes Reusable Chunks #24032

sebmarkbage opened this issue Mar 4, 2022 · 0 comments · Fixed by #24034
Labels
React 18 Bug reports, questions, and general feedback about React 18 Type: Bug

Comments

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Mar 4, 2022 •
edited
Loading

cloudflare/miniflare#203

We switched to using "bytes" streams but, by spec, chunks get transferred in that format. Totally reasonable. However, we pass reusable chunks which then get detached. I'm not sure why the polyfill or fixtures didn't catch this.

We really should be using the byob model instead and copy into a larger chunk for perf anyway so this just makes that more urgent.
@sebmarkbage sebmarkbage added Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug React 18 Bug reports, questions, and general feedback about React 18 Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Mar 4, 2022
@gnoff gnoff mentioned this issue Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
React 18 Bug reports, questions, and general feedback about React 18 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fizz] write chunks to a buffer with no re-use gnoff/react
1 participant
@sebmarkbage