Skip to content

Commit cc8cb14

Browse files
authored
Flow: add some missing types in react-reconciler (#25316)
To enable the next Flow version, we need to annotate exported values. This adds a few automatically inferred types that didn't look huge or just `any`.
1 parent 112d049 commit cc8cb14

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

packages/react-reconciler/src/ReactFiber.new.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ export function createFiberFromSuspense(
693693
mode: TypeOfMode,
694694
lanes: Lanes,
695695
key: null | string,
696-
) {
696+
): Fiber {
697697
const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
698698
fiber.elementType = REACT_SUSPENSE_TYPE;
699699
fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
705705
mode: TypeOfMode,
706706
lanes: Lanes,
707707
key: null | string,
708-
) {
708+
): Fiber {
709709
const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
710710
fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
711711
fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
717717
mode: TypeOfMode,
718718
lanes: Lanes,
719719
key: null | string,
720-
) {
720+
): Fiber {
721721
const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
722722
fiber.elementType = REACT_OFFSCREEN_TYPE;
723723
fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
736736
mode: TypeOfMode,
737737
lanes: Lanes,
738738
key: null | string,
739-
) {
739+
): Fiber {
740740
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
741741
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
742742
fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
757757
mode: TypeOfMode,
758758
lanes: Lanes,
759759
key: null | string,
760-
) {
760+
): Fiber {
761761
const fiber = createFiber(CacheComponent, pendingProps, key, mode);
762762
fiber.elementType = REACT_CACHE_TYPE;
763763
fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
769769
mode: TypeOfMode,
770770
lanes: Lanes,
771771
key: null | string,
772-
) {
772+
): Fiber {
773773
const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
774774
fiber.elementType = REACT_TRACING_MARKER_TYPE;
775775
fiber.lanes = lanes;

packages/react-reconciler/src/ReactFiber.old.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ export function createFiberFromSuspense(
693693
mode: TypeOfMode,
694694
lanes: Lanes,
695695
key: null | string,
696-
) {
696+
): Fiber {
697697
const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
698698
fiber.elementType = REACT_SUSPENSE_TYPE;
699699
fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
705705
mode: TypeOfMode,
706706
lanes: Lanes,
707707
key: null | string,
708-
) {
708+
): Fiber {
709709
const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
710710
fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
711711
fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
717717
mode: TypeOfMode,
718718
lanes: Lanes,
719719
key: null | string,
720-
) {
720+
): Fiber {
721721
const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
722722
fiber.elementType = REACT_OFFSCREEN_TYPE;
723723
fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
736736
mode: TypeOfMode,
737737
lanes: Lanes,
738738
key: null | string,
739-
) {
739+
): Fiber {
740740
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
741741
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
742742
fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
757757
mode: TypeOfMode,
758758
lanes: Lanes,
759759
key: null | string,
760-
) {
760+
): Fiber {
761761
const fiber = createFiber(CacheComponent, pendingProps, key, mode);
762762
fiber.elementType = REACT_CACHE_TYPE;
763763
fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
769769
mode: TypeOfMode,
770770
lanes: Lanes,
771771
key: null | string,
772-
) {
772+
): Fiber {
773773
const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
774774
fiber.elementType = REACT_TRACING_MARKER_TYPE;
775775
fiber.lanes = lanes;

packages/react-reconciler/src/ReactFiberAct.new.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
3737
return false;
3838
}
3939

40-
export function isConcurrentActEnvironment() {
40+
export function isConcurrentActEnvironment(): void | boolean {
4141
if (__DEV__) {
4242
const isReactActEnvironmentGlobal =
4343
// $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global

packages/react-reconciler/src/ReactFiberAct.old.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
3737
return false;
3838
}
3939

40-
export function isConcurrentActEnvironment() {
40+
export function isConcurrentActEnvironment(): void | boolean {
4141
if (__DEV__) {
4242
const isReactActEnvironmentGlobal =
4343
// $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global

0 commit comments

Comments
 (0)