-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when enabling Performance Monitor on iOS 13.4 #28512
Fix crash when enabling Performance Monitor on iOS 13.4 #28512
Conversation
Base commit: 3a11f05 |
Base commit: 3a11f05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @IjzerenHein in e2c417f. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: #28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: #28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR expo#21 has been shipped and tested in Expo Client 37 Fixes #28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: facebook#28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: facebook#28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR expo#21 has been shipped and tested in Expo Client 37 Fixes facebook#28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
Summary
This PR fixes a crash when opening the Performance Monitor on iOS 13.4.
Detailed info: #28414
Changelog
[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4
How
This PR prevents the JavaScriptCore option from being set altogether.
This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage.
Test Plan
Tested on iOS 13.4 (simulator):
Tested on iOS 13.1 (simulator)
setOption
was called, but the Performance Monitor didn't show any GC usage regardless.Fixes #28414