Skip to content

Commit e64e13f

Browse files
hramosfacebook-github-bot
authored andcommittedJul 18, 2018
Bump minimum Node version to 8.3 (#20236)
Summary: Node rest/spread syntax started working without the harmony flag in 8.3 (#20178 (comment)). Release Notes: [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8.3 Pull Request resolved: #20236 Differential Revision: D8876357 Pulled By: hramos fbshipit-source-id: 1f5f791ef318e70c6be8b23d887a1d650a68e594
1 parent 2d1fabb commit e64e13f

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed
 

‎local-cli/server/checkNodeVersion.js

+5-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ var formatBanner = require('metro-core/src/formatBanner');
1414
var semver = require('semver');
1515

1616
module.exports = function() {
17-
if (!semver.satisfies(process.version, '>=8')) {
17+
if (!semver.satisfies(process.version, '>=8.3')) {
1818
var engine = semver.satisfies(process.version, '<1') ? 'Node' : 'io.js';
1919

2020
var message =
@@ -24,15 +24,12 @@ module.exports = function() {
2424
process.version +
2525
'.\n' +
2626
'\n' +
27-
'React Native runs on Node 8.0 or newer. There are several ways to ' +
27+
'React Native runs on Node 8.3 or newer. There are several ways to ' +
2828
'upgrade Node.js depending on your preference.\n' +
2929
'\n' +
30-
'nvm: nvm install node && nvm alias default node\n' +
31-
'Homebrew: brew unlink iojs; brew install node\n' +
32-
'Installer: download the Mac .pkg from https://nodejs.org/\n' +
33-
'\n' +
34-
'About Node.js: https://nodejs.org\n' +
35-
'Follow along at: https://github.com/facebook/react-native/issues/19226';
30+
'nvm: nvm install 8.3 --reinstall-packages-from=node\n' +
31+
'Homebrew: brew update && brew upgrade node\n' +
32+
'Installer: download from https://nodejs.org/\n';
3633
console.log(
3734
formatBanner(message, {
3835
chalkFunction: chalk.green,

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"url": "git@github.com:facebook/react-native.git"
99
},
1010
"engines": {
11-
"node": ">=8"
11+
"node": ">=8.3"
1212
},
1313
"prettier": {
1414
"requirePragma": true,

0 commit comments

Comments
 (0)