Skip to content

Commit c09d509

Browse files
ikesyofacebook-github-bot
authored andcommittedMay 24, 2018
Fix CocoaPods integration without DevSupport subspec
Summary: This is the thing which is handled in https://github.com/orta/cocoapods-fix-react-native today. https://github.com/orta/cocoapods-fix-react-native/blob/89a78ad34950b5d6b3de657914c8ced8bf37ee8e/lib/cocoapods-fix-react-native/versions/0_55_3-post.rb#L140-L164 This should be the correct fix for #17799. <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> Integrating React Native into an existing iOS project using CocoaPods without `DevSupport` subspec and seeing if the project successfully compiles. <!-- Required. Help reviewers and the release process by writing your own release notes. See below for an example. --> [IOS] [BUGFIX] [DevSupport] - Fix CocoaPods integration without DevSupport subspec Closes #19265 Differential Revision: D8149786 Pulled By: hramos fbshipit-source-id: c665e463b76aacdfb2022e82e36eb381d2d9ff2b
1 parent e1a36fc commit c09d509

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed
 

‎React/Modules/RCTDevSettings.mm

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#import "RCTEventDispatcher.h"
1919
#import "RCTJSCSamplingProfiler.h"
2020
#import "RCTLog.h"
21-
#import "RCTPackagerClient.h"
2221
#import "RCTProfile.h"
2322
#import "RCTUtils.h"
2423

@@ -35,6 +34,7 @@
3534
static NSString *const kRCTDevSettingsUserDefaultsKey = @"RCTDevMenu";
3635

3736
#if ENABLE_PACKAGER_CONNECTION
37+
#import "RCTPackagerClient.h"
3838
#import "RCTPackagerConnection.h"
3939
#endif
4040

@@ -201,6 +201,7 @@ - (void)setBridge:(RCTBridge *)bridge
201201
#endif
202202
}
203203

204+
#if ENABLE_PACKAGER_CONNECTION
204205
static void pokeSamplingProfiler(RCTBridge *const bridge, RCTPackagerClientResponder *const responder)
205206
{
206207
if (!bridge) {
@@ -224,6 +225,7 @@ static void pokeSamplingProfiler(RCTBridge *const bridge, RCTPackagerClientRespo
224225
[responder respondWithResult:results];
225226
}
226227
}
228+
#endif
227229

228230
- (dispatch_queue_t)methodQueue
229231
{

0 commit comments

Comments
 (0)
Please sign in to comment.